From: Anatolij Gustschin <agust@denx.de>
To: stillcompiling@gmail.com, joshua.clayton@uniwest.com, bst@pengutronix.de
Cc: linux-fpga@vger.kernel.org, atull@kernel.org,
moritz.fischer@ettus.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date: Thu, 18 May 2017 13:46:59 +0200 [thread overview]
Message-ID: <20170518134659.589b681b@crub> (raw)
In-Reply-To: <1495045422-19183-2-git-send-email-agust@denx.de>
Hi,
On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@denx.de wrote:
...
>+ conf->spi = spi;
>+ conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
we should use GPIOD_OUT_LOW flags here. nCONFIG is low active, so
setting logical high will enable the signal (drive the pin low),
resulting in configuration reset for already initialised FPGAs when
loading/reloading the module.
Thanks,
Anatolij
next prev parent reply other threads:[~2017-05-18 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 18:23 [PATCH v10 1/3] doc: dt: add altera-ps-spi binding document Anatolij Gustschin
[not found] ` <1495045422-19183-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-05-17 18:23 ` [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs Anatolij Gustschin
2017-05-18 11:46 ` Anatolij Gustschin [this message]
[not found] ` <1495045422-19183-2-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2017-05-18 20:59 ` Anatolij Gustschin
2017-05-17 18:23 ` [PATCH v10 3/3] ARM: dts: imx6q-evi: support cyclone-ps-spi Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518134659.589b681b@crub \
--to=agust@denx.de \
--cc=atull@kernel.org \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=joshua.clayton@uniwest.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).