From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64
Date: Fri, 19 May 2017 09:19:22 +0200 [thread overview]
Message-ID: <20170519071922.awmib4qphl6ac6mj@flea.home> (raw)
In-Reply-To: <79B00D42-3F95-4D5E-9A23-8E893CCF2462-h8G6r0blFSE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Fri, May 19, 2017 at 11:03:33AM +0800, Icenowy Zheng wrote:
> >The patch looks OK, but given the module is removable, I think it
> >should be
> >an overlay. The overlay would enable WiFi + Bluetooth, and all the
> >peripherals needed to connect them.
> >
> >That way, if the module is not installed, we avoid confusing the user
> >with
> >unused peripherals, and avoid having live voltage on an unoccupied
> >header.
>
> But as this header have specific usage, we will also confuse user
> if it's not enabled as its target usage.
Yet you would enable unused resources.
This was already pointed out here:
https://patchwork.kernel.org/patch/9670235/
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-05-19 7:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 7:16 [PATCH v6 0/9] AXP803 PMIC support for Pine64 Icenowy Zheng
[not found] ` <20170518071653.36561-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-18 7:16 ` [PATCH v6 1/9] irqchip/sunxi-nmi: add A64 R_INTC to the binding doc Icenowy Zheng
[not found] ` <20170518071653.36561-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-18 7:40 ` Chen-Yu Tsai
2017-05-18 7:52 ` Maxime Ripard
2017-05-18 7:16 ` [PATCH v6 2/9] irqchip/sunxi-nmi: add support for the NMI in A64 R_INTC Icenowy Zheng
[not found] ` <20170518071653.36561-3-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-18 7:52 ` Maxime Ripard
[not found] ` <20170518075227.ifjbaahp7bz4ektr-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 2:27 ` Chen-Yu Tsai
2017-05-22 9:39 ` Marc Zyngier
[not found] ` <ed99d87b-86eb-cf8a-8614-51d59fa00c8c-5wv7dgnIgG8@public.gmane.org>
2017-05-22 9:41 ` Icenowy Zheng
[not found] ` <98014597-29BA-4D02-8137-4E399955F4FD-h8G6r0blFSE@public.gmane.org>
2017-05-22 14:25 ` [linux-sunxi] " Chen-Yu Tsai
[not found] ` <CAGb2v66NY49OL0J3C64CKzngri5-Na6uPBizj-BNJW3vNkFUQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-05 5:57 ` Chen-Yu Tsai
2017-06-05 7:53 ` [linux-sunxi] " Marc Zyngier
[not found] ` <854343de-2415-c310-cc5e-0b5abbd71af5-5wv7dgnIgG8@public.gmane.org>
2017-06-05 7:56 ` Icenowy Zheng
[not found] ` <0A01E9A3-7CFA-415B-B862-2D94990BA169-h8G6r0blFSE@public.gmane.org>
2017-06-05 8:05 ` Marc Zyngier
2017-05-18 7:16 ` [PATCH v6 3/9] arm64: allwinner: a64: add NMI (R_INTC) controller on A64 Icenowy Zheng
[not found] ` <20170518071653.36561-4-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 2:28 ` [linux-sunxi] " Chen-Yu Tsai
2017-05-18 7:16 ` [PATCH v6 4/9] arm64: allwinner: a64: add AXP803 node to Pine64 device tree Icenowy Zheng
[not found] ` <20170518071653.36561-5-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 2:28 ` Chen-Yu Tsai
[not found] ` <CAGb2v67w=miCHB-3f39vrx_+iZuEJEo9UyrFLw6aPPYWPweJXQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-18 3:02 ` [linux-sunxi] " Chen-Yu Tsai
2017-05-18 7:16 ` [PATCH v6 5/9] regulator: axp20x-regulator: add support for AXP803 Icenowy Zheng
2017-05-18 7:16 ` [PATCH v6 6/9] mfd: axp20x: add axp20x-regulator cell " Icenowy Zheng
[not found] ` <20170518071653.36561-7-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-22 12:17 ` Lee Jones
2017-05-18 7:16 ` [PATCH v6 7/9] arm64: allwinner: a64: add DTSI file for AXP803 PMIC Icenowy Zheng
[not found] ` <20170518071653.36561-8-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 2:29 ` Chen-Yu Tsai
[not found] ` <CAGb2v65xZC_iAf4HS6MWX5XbU-J0uUAN0FtAj6TxwD-peEt2mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-18 3:02 ` Chen-Yu Tsai
2017-05-18 7:16 ` [PATCH v6 8/9] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
[not found] ` <20170518071653.36561-9-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 2:54 ` Chen-Yu Tsai
[not found] ` <CAGb2v646i-zonDa+o-E_9k8i2_dqbEzQCNrEPw-+w-EEuat6nw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-19 3:00 ` [linux-sunxi] " Icenowy Zheng
[not found] ` <8610FFF7-148D-4582-8AAC-6A1BB771C9F7-h8G6r0blFSE@public.gmane.org>
2017-05-19 3:10 ` Chen-Yu Tsai
[not found] ` <CAGb2v66utRHYXDoG4UPgbrebgHdKne7FZcA+b4M+Ns1rEGN24g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-19 3:12 ` Icenowy Zheng
2017-05-19 8:27 ` Andre Przywara
[not found] ` <98ae1ea8-ef08-8859-63d8-57c56a6348a6-5wv7dgnIgG8@public.gmane.org>
2017-05-19 8:29 ` Icenowy Zheng
[not found] ` <4B129FD0-4AEB-4DC3-AF33-C279468BD197-h8G6r0blFSE@public.gmane.org>
2017-05-19 8:55 ` [linux-sunxi] " Andre Przywara
[not found] ` <77045320-c19a-6c18-ed68-108fa5416c2a-5wv7dgnIgG8@public.gmane.org>
2017-07-18 2:58 ` Chen-Yu Tsai
[not found] ` <CAGb2v65Fn4rvyLyZaFHfmUFQNq3ctN0+tG_fg24YhPpi-Vr8hA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-18 3:07 ` [linux-sunxi] " Icenowy Zheng
2017-05-19 8:56 ` Maxime Ripard
2017-05-18 7:16 ` [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi " Icenowy Zheng
[not found] ` <20170518071653.36561-10-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-19 3:01 ` Chen-Yu Tsai
[not found] ` <CAGb2v66mqMveibKKU9LiBm8jzAOj46hFCK6HvJx0k6077fqLZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-19 3:03 ` [linux-sunxi] " Icenowy Zheng
[not found] ` <79B00D42-3F95-4D5E-9A23-8E893CCF2462-h8G6r0blFSE@public.gmane.org>
2017-05-19 7:19 ` Maxime Ripard [this message]
[not found] ` <20170519071922.awmib4qphl6ac6mj-YififvaboMKzQB+pC5nmwQ@public.gmane.org>
2017-05-19 7:22 ` icenowy-h8G6r0blFSE
[not found] ` <16dee602b96510170ee1117cfaae0025-h8G6r0blFSE@public.gmane.org>
2017-05-23 14:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519071922.awmib4qphl6ac6mj@flea.home \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-h8G6r0blFSE@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).