From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Vinod Koul <vinod.koul@intel.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt
Date: Fri, 19 May 2017 11:05:02 +0200 [thread overview]
Message-ID: <20170519090502.GA26864@bigcity.dyn.berto.se> (raw)
In-Reply-To: <1495178867-817-1-git-send-email-geert+renesas@glider.be>
Hi Geert,
On 2017-05-19 09:27:47 +0200, Geert Uytterhoeven wrote:
> The documentation for the "interrupt-names" property only mentions the
> per-channel interrupts, while the error interrupt has always been
> mandatory, too.
>
> Fixes: 10f5c8438475909a ("dmaengine: rcar-dmac: Add device tree bindings
> documentation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> index 3316a9c2e638b98c..79a204d50234f287 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
> @@ -30,8 +30,9 @@ Required Properties:
>
> - interrupts: interrupt specifiers for the DMAC, one for each entry in
> interrupt-names.
> -- interrupt-names: one entry per channel, named "ch%u", where %u is the
> - channel number ranging from zero to the number of channels minus one.
> +- interrupt-names: one entry for the error interrupt, named "error", plus one
> + entry per channel, named "ch%u", where %u is the channel number ranging from
> + zero to the number of channels minus one.
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> - clock-names: "fck" for the functional clock
> - clocks: a list of phandle + clock-specifier pairs, one for each entry
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2017-05-19 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 7:27 [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt Geert Uytterhoeven
2017-05-19 9:05 ` Niklas Söderlund [this message]
2017-05-19 9:28 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519090502.GA26864@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).