[PATCH 0/2] orange-pi-zero: minor updates for board peripherals

[PATCH 0/2] orange-pi-zero: minor updates for board peripherals

[Sergey Matyukevich]

Hi all,

These two patches simplify the use of orange-pi-zero board
right out of the box:

- add interrupt triggering for the on-board XR819 SDIO WiFi chip
- enable on-board SPI NOR

Regards,
Sergey

sun8i-h2-plus-orangepi-zero.dts |   18 ++++++++++++++++++
1 file changed, 18 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip

[Sergey Matyukevich]

Specify interrupt triggering for XR819 SDIO WiFi chip
on orange-pi-zero board.

For more details see: http://linux-sunxi.org/Wifi#Allwinner

Signed-off-by: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
index 9e8b082c134f..34e4a5a80136 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -128,6 +128,8 @@
 	 */
 	xr819: sdio_wifi@1 {
 		reg = <1>;
+		interrupt-parent = <&pio>;
+		interrupts = <6 10 IRQ_TYPE_EDGE_RISING>;
 	};
 };
 
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hi Sergey,

Thanks for your patches!

On Sat, May 20, 2017 at 12:35:49AM +0300, Sergey Matyukevich wrote:
> Specify interrupt triggering for XR819 SDIO WiFi chip
> on orange-pi-zero board.
> 
> For more details see: http://linux-sunxi.org/Wifi#Allwinner

Please don't reference details in a wiki page. URLs can change and
wiki page get rewritten. git history is immutable. Your commit log
should contain everything there is.

The patch itself looks good though.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 1/2] ARM: dts: orange-pi-zero: interrupt triggering for XR819 WiFi chip

[Sergey Matyukevich]

> > 
> > For more details see: http://linux-sunxi.org/Wifi#Allwinner
> 
> Please don't reference details in a wiki page. URLs can change and
> wiki page get rewritten. git history is immutable. Your commit log
> should contain everything there is.
> 
> The patch itself looks good though.

Ok, I will provide a more detailed commit message and resubmit.

Thanks,
Sergey

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR

[Sergey Matyukevich]

Enable SPI NOR on orange-pi-zero board.

For more information see:
- http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash

Signed-off-by: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
index 34e4a5a80136..fe39e96cee65 100644
--- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
+++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
@@ -177,3 +177,19 @@
 	status = "okay";
 	usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
 };
+
+&spi0 {
+	status = "okay";
+
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
+		reg = <0>;
+		spi-max-frequency = <40000000>;
+
+		partition@00000000 {
+			reg = <0x00000000 0x200000>;	/* 2Mb */
+		};
+	};
+};
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

Hi Sergey,

On Sat, May 20, 2017 at 12:35:50AM +0300, Sergey Matyukevich wrote:
> Enable SPI NOR on orange-pi-zero board.
> 
> For more information see:
> - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash

Same remark here than on the first patch

> 
> Signed-off-by: Sergey Matyukevich <geomatsi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index 34e4a5a80136..fe39e96cee65 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -177,3 +177,19 @@
>  	status = "okay";
>  	usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
>  };
> +
> +&spi0 {
> +	status = "okay";
> +
> +	flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> +		reg = <0>;
> +		spi-max-frequency = <40000000>;

How do the other OPi Zero that doesn't have that SPI flash behave?

> +
> +		partition@00000000 {
> +			reg = <0x00000000 0x200000>;	/* 2Mb */
> +		};

There's no need to create a first partition, this needs to be
user-defined.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR

[Sergey Matyukevich]

> > For more information see:
> > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
> 
> Same remark here than on the first patch

Ok, I will provide a more detailed commit message
w/o external references.

> > +&spi0 {
> > +	status = "okay";
> > +
> > +	flash@0 {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > +		reg = <0>;
> > +		spi-max-frequency = <40000000>;
> 
> How do the other OPi Zero that doesn't have that SPI flash behave?
Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash
was optional in the first production batch in Dec 2016. In later
batches flash chip was pre-populated. However there are should
be quite a few boards around which do not have flash.

Does it make sense to set status to 'disabled' by default adding
appropriate comment in the commit message ?

> > +
> > +		partition@00000000 {
> > +			reg = <0x00000000 0x200000>;	/* 2Mb */
> > +		};
> 
> There's no need to create a first partition, this needs to be
> user-defined.

Ok, than it probably makes sense to drop it from dts. User-defined
list of partitions can be passed via kernel command line.

Thanks,
Sergey

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: dts: orange-pi-zero: enable SPI NOR

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

Hi Sergey,

On Mon, May 22, 2017 at 11:30:12PM +0300, Sergey Matyukevich wrote:
> > > For more information see:
> > > - http://linux-sunxi.org/Orange_Pi_Zero#SPI_NOR_flash
> > 
> > Same remark here than on the first patch
> 
> Ok, I will provide a more detailed commit message
> w/o external references.
> 
> > > +&spi0 {
> > > +	status = "okay";
> > > +
> > > +	flash@0 {
> > > +		#address-cells = <1>;
> > > +		#size-cells = <1>;
> > > +		compatible = "mxicy,mx25l1606e", "winbond,w25q128";
> > > +		reg = <0>;
> > > +		spi-max-frequency = <40000000>;
> > 
> > How do the other OPi Zero that doesn't have that SPI flash behave?
>
> Hmmm. Good point. According to linux-sunxi.org docs SPI NOR flash
> was optional in the first production batch in Dec 2016. In later
> batches flash chip was pre-populated. However there are should
> be quite a few boards around which do not have flash.
> 
> Does it make sense to set status to 'disabled' by default adding
> appropriate comment in the commit message ?

If it's just that the driver fails to probe, we can live with that I
guess. If not, then yes, that's a solution too.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]