From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 2/6] clk: sunxi-ng: a83t: Fix audio PLL divider offset
Date: Mon, 22 May 2017 09:45:27 +0200 [thread overview]
Message-ID: <20170522074527.4ru2oad4neyiblnp@flea.lan> (raw)
In-Reply-To: <CAGb2v65SUR2NvGOFFgzUpDh_9Dm6SAhzwC31KBOqFZubOhkK9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
On Mon, May 22, 2017 at 03:35:57PM +0800, Chen-Yu Tsai wrote:
> On Mon, May 22, 2017 at 3:20 PM, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > On Mon, May 22, 2017 at 02:25:48PM +0800, Chen-Yu Tsai wrote:
> >> The divider of the audio PLL has an offset of 1.
> >> Fix this in the driver.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> >
> > Applied, thanks!
>
> So even with this patch applied, the audio is still slow and off pitch.
> It's even worse without this patch...
>
> Maybe it's time we added a special class of clks for the audio PLL
> to deal with sigma-delta modulation of the divider?
I'm not sure how feasible that would be and what it would look like,
but you can give it a shot yes.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-22 7:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 6:25 [PATCH 0/6] ARM: sun8i: a83t: Enable SPDIF output support Chen-Yu Tsai
[not found] ` <20170522062552.19026-1-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 6:25 ` [PATCH 1/6] clk: sunxi-ng: a83t: Fix PLL lock status register offset Chen-Yu Tsai
[not found] ` <20170522062552.19026-2-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:21 ` Maxime Ripard
2017-05-22 6:25 ` [PATCH 2/6] clk: sunxi-ng: a83t: Fix audio PLL divider offset Chen-Yu Tsai
[not found] ` <20170522062552.19026-3-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:20 ` Maxime Ripard
[not found] ` <20170522072047.bffdbwkz2nqvhums-ZC1Zs529Oq4@public.gmane.org>
2017-05-22 7:35 ` Chen-Yu Tsai
[not found] ` <CAGb2v65SUR2NvGOFFgzUpDh_9Dm6SAhzwC31KBOqFZubOhkK9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-22 7:45 ` Maxime Ripard [this message]
2017-05-22 6:25 ` [PATCH 3/6] pinctrl: sunxi: Fix SPDIF function name for A83T Chen-Yu Tsai
[not found] ` <20170522062552.19026-4-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:21 ` Maxime Ripard
2017-05-23 9:32 ` Linus Walleij
2017-05-22 6:25 ` [PATCH 4/6] ARM: sun8i: a83t: Add device node for DMA controller Chen-Yu Tsai
2017-05-22 7:18 ` [linux-sunxi] " Code Kipper
[not found] ` <CAEKpxB=daPuD0YNToTiEzcD0VAUjVen0nTDY0BhkLfQzcLFoTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-22 7:20 ` Chen-Yu Tsai
2017-05-22 7:24 ` [linux-sunxi] " Maxime Ripard
[not found] ` <20170522062552.19026-5-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:23 ` Maxime Ripard
2017-05-22 6:25 ` [PATCH 5/6] ARM: sun8i: a83t: Add device node for SPDIF transmitter Chen-Yu Tsai
[not found] ` <20170522062552.19026-6-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:24 ` Maxime Ripard
2017-05-22 6:25 ` [PATCH 6/6] ARM: sun8i: a83t: cubietruck-plus: Enable SPDIF output Chen-Yu Tsai
[not found] ` <20170522062552.19026-7-wens-jdAy2FN1RRM@public.gmane.org>
2017-05-22 7:25 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522074527.4ru2oad4neyiblnp@flea.lan \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).