From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/6] clk: sunxi-ng: a83t: Fix audio PLL divider offset Date: Mon, 22 May 2017 09:45:27 +0200 Message-ID: <20170522074527.4ru2oad4neyiblnp@flea.lan> References: <20170522062552.19026-1-wens@csie.org> <20170522062552.19026-3-wens@csie.org> <20170522072047.bffdbwkz2nqvhums@flea.lan> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ckazgmfm5xncmord" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Linus Walleij , devicetree , linux-arm-kernel , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: devicetree@vger.kernel.org --ckazgmfm5xncmord Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Mon, May 22, 2017 at 03:35:57PM +0800, Chen-Yu Tsai wrote: > On Mon, May 22, 2017 at 3:20 PM, Maxime Ripard > wrote: > > On Mon, May 22, 2017 at 02:25:48PM +0800, Chen-Yu Tsai wrote: > >> The divider of the audio PLL has an offset of 1. > >> Fix this in the driver. > >> > >> Signed-off-by: Chen-Yu Tsai > > > > Applied, thanks! > > So even with this patch applied, the audio is still slow and off pitch. > It's even worse without this patch... > > Maybe it's time we added a special class of clks for the audio PLL > to deal with sigma-delta modulation of the divider? I'm not sure how feasible that would be and what it would look like, but you can give it a shot yes. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ckazgmfm5xncmord--