[PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[Martin Kepplinger]

The datasheet and application note does not mention an allowed range for
the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
T5x06 touch.

So, lacking a known lower limit, we increase the range for thresholds,
and set the lower limit to 0. The documentation is updated accordingly.

Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
 Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
 drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
index 6db2210..025cf8c 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
@@ -36,7 +36,7 @@ Optional properties:
                 control gpios
 
  - threshold:   allows setting the "click"-threshold in the range
-                from 20 to 80.
+                from 0 to 80.
 
  - gain:        allows setting the sensitivity in the range from 0 to
                 31. Note that lower values indicate higher
diff --git a/Documentation/input/devices/edt-ft5x06.rst b/Documentation/input/devices/edt-ft5x06.rst
index 2032f0b..1ccc94b 100644
--- a/Documentation/input/devices/edt-ft5x06.rst
+++ b/Documentation/input/devices/edt-ft5x06.rst
@@ -15,7 +15,7 @@ It has been tested with the following devices:
 The driver allows configuration of the touch screen via a set of sysfs files:
 
 /sys/class/input/eventX/device/device/threshold:
-    allows setting the "click"-threshold in the range from 20 to 80.
+    allows setting the "click"-threshold in the range from 0 to 80.
 
 /sys/class/input/eventX/device/device/gain:
     allows setting the sensitivity in the range from 0 to 31. Note that
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 8cf8d8d..f872817 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -471,7 +471,7 @@ static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN,
 static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET,
 		M09_REGISTER_OFFSET, 0, 31);
 static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD,
-		M09_REGISTER_THRESHOLD, 20, 80);
+		M09_REGISTER_THRESHOLD, 0, 80);
 static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE,
 		NO_REGISTER, 3, 14);
 
-- 
2.1.4

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[Rob Herring]

On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
> The datasheet and application note does not mention an allowed range for
> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
> T5x06 touch.
> 
> So, lacking a known lower limit, we increase the range for thresholds,
> and set the lower limit to 0. The documentation is updated accordingly.
> 
> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>  Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
>  drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[Martin Kepplinger]

On 2017-05-08 18:11, Rob Herring wrote:
> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
>> The datasheet and application note does not mention an allowed range for
>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
>> T5x06 touch.
>>
>> So, lacking a known lower limit, we increase the range for thresholds,
>> and set the lower limit to 0. The documentation is updated accordingly.
>>
>> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
>> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>> ---
>>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>>  Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
>>  drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

Dmitry, any objections or thoughts?

thanks
                       martin

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[Martin Kepplinger]

On 2017-05-11 10:32, Martin Kepplinger wrote:
> On 2017-05-08 18:11, Rob Herring wrote:
>> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
>>> The datasheet and application note does not mention an allowed range for
>>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
>>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
>>> T5x06 touch.
>>>
>>> So, lacking a known lower limit, we increase the range for thresholds,
>>> and set the lower limit to 0. The documentation is updated accordingly.
>>>
>>> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
>>> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>> ---
>>>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>>>  Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
>>>  drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>>
> 
> Dmitry, any objections or thoughts?

Hey Dmitry, this still applies to today's -next and wouldn't take too
long for you to review :)

thanks

                      martin

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

[Dmitry Torokhov]

On Mon, May 08, 2017 at 11:11:46AM -0500, Rob Herring wrote:
> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
> > The datasheet and application note does not mention an allowed range for
> > the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
> > lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
> > T5x06 touch.
> > 
> > So, lacking a known lower limit, we increase the range for thresholds,
> > and set the lower limit to 0. The documentation is updated accordingly.
> > 
> > Signed-off-by: Schoefegger Stefan <stefan.schoefegger-hfTNJOUbDMh54TAoqtyWWQ@public.gmane.org>
> > Signed-off-by: Manfred Schlaegl <manfred.schlaegl-hfTNJOUbDMh54TAoqtyWWQ@public.gmane.org>
> > Signed-off-by: Martin Kepplinger <martin.kepplinger-hfTNJOUbDMh54TAoqtyWWQ@public.gmane.org>
> > ---
> >  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
> >  Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
> >  drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Applied, thank you.


-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html