From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Cameron Subject: Re: [PATCH] ASoC: Add pcm9211 driver Date: Wed, 24 May 2017 07:16:24 +1000 Message-ID: <20170523211624.GA3245@us.netrek.org> References: <20170523090931.9697-1-julian@jusst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170523090931.9697-1-julian@jusst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Julian Scheel Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, ckeepax@opensource.wolfsonmicro.com, lars@metafoo.de List-Id: devicetree@vger.kernel.org On Tue, May 23, 2017 at 11:09:31AM +0200, Julian Scheel wrote: > This adds a driver for the TI PCM9211 digital audio interfaces > transceiver. The driver currently only handles the receiver aspect of > the chip and supports only control of the primary I2S (MAIN) output > port. Support for AUX output is trivial to add, but wasn't done due to > missing hardware for testing. The same goes for the transmitter > functionality. > The driver uses some extra device-tree fields to allow configuration of > pin functions directly out of this driver. > > Signed-off-by: Julian Scheel > --- > .../devicetree/bindings/sound/pcm9211.txt | 118 ++ > MAINTAINERS | 6 + > include/dt-bindings/sound/pcm9211.h | 55 + > sound/soc/codecs/Kconfig | 10 + > sound/soc/codecs/Makefile | 4 + > sound/soc/codecs/pcm9211-i2c.c | 65 + > sound/soc/codecs/pcm9211.c | 1357 ++++++++++++++++++++ > sound/soc/codecs/pcm9211.h | 206 +++ > 8 files changed, 1821 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/pcm9211.txt > create mode 100644 include/dt-bindings/sound/pcm9211.h > create mode 100644 sound/soc/codecs/pcm9211-i2c.c > create mode 100644 sound/soc/codecs/pcm9211.c > create mode 100644 sound/soc/codecs/pcm9211.h > > [...] > diff --git a/sound/soc/codecs/pcm9211.c b/sound/soc/codecs/pcm9211.c > new file mode 100644 > index 000000000000..0ab4ad551df8 > --- /dev/null > +++ b/sound/soc/codecs/pcm9211.c > @@ -0,0 +1,1357 @@ > [...] > +int pcm9211_probe(struct device *dev, struct regmap *regmap) > +{ > [...] > + priv->int0 = devm_gpiod_get_optional(dev, "int0", GPIOD_IN); > + if (IS_ERR(priv->reset)) { > + ret = PTR_ERR(priv->reset); > + dev_err(dev, "Failed to get reset gpio: %d\n", ret); > + return ret; > + } In above block; reset should be int0, three lines affected. -- James Cameron http://quozl.netrek.org/