From: Leo Yan <leo.yan@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>, Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH v11 7/9] coresight: add support for CPU debug module
Date: Wed, 24 May 2017 08:14:51 +0800 [thread overview]
Message-ID: <20170524001451.GA20279@leoy-ThinkPad-T440> (raw)
In-Reply-To: <CANLsYkzosO8+uaphvNQFe80zOJoqkSWceaiWhKEH-xSuVH0uew@mail.gmail.com>
Hi Mathieu,
On Tue, May 23, 2017 at 11:39:16AM -0600, Mathieu Poirier wrote:
[...]
> > +static bool debug_enable;
> > +module_param_named(enable, debug_enable, bool, 0600);
> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality "
> > + "(default is 0, which means is disabled by default)");
>
> Checkpatch complains about a quoted string split across multiple
> lines. You can probably removes the second one since information
> about the default value is already detailed in patch 03/09. In this
> case I suggest modifiying the description to:
>
> "Control to enable coresight CPU debug functionality"
It's shame for checkpatch.pl warning. Although everytime I used script
before sending out patch set, should think a bit more to handle them
better. Have sent new patch set to dismiss them.
Thanks,
Leo Yan
next prev parent reply other threads:[~2017-05-24 0:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 14:16 [PATCH v11 0/9] coresight: enable debug module Leo Yan
2017-05-23 14:16 ` [PATCH v11 1/9] coresight: bindings for CPU " Leo Yan
2017-05-23 14:16 ` [PATCH v11 2/9] doc: Add documentation for Coresight CPU debug Leo Yan
2017-05-23 14:16 ` [PATCH v11 3/9] doc: Add coresight_cpu_debug.enable to kernel-parameters.txt Leo Yan
2017-05-23 14:16 ` [PATCH v11 4/9] MAINTAINERS: update file entries for Coresight subsystem Leo Yan
2017-05-23 14:16 ` [PATCH v11 5/9] coresight: of_get_coresight_platform_data: Add missing of_node_put Leo Yan
2017-05-23 14:16 ` [PATCH v11 6/9] coresight: refactor with function of_coresight_get_cpu Leo Yan
2017-05-23 14:16 ` [PATCH v11 7/9] coresight: add support for CPU debug module Leo Yan
2017-05-23 17:39 ` Mathieu Poirier
2017-05-24 0:14 ` Leo Yan [this message]
2017-05-24 13:55 ` kbuild test robot
2017-05-23 14:16 ` [PATCH v11 8/9] arm64: dts: hi6220: register " Leo Yan
[not found] ` <1495548980-30432-9-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-23 16:29 ` Mathieu Poirier
2017-05-23 14:16 ` [PATCH v11 9/9] arm64: dts: qcom: msm8916: Add debug unit Leo Yan
2017-05-23 16:31 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524001451.GA20279@leoy-ThinkPad-T440 \
--to=leo.yan@linaro.org \
--cc=andy.gross@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox