From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH V3 1/2] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc Date: Thu, 25 May 2017 15:42:59 +0800 Message-ID: <20170525074255.GY26102@dragon> References: <1495539829-23345-1-git-send-email-aisheng.dong@nxp.com> <20170523182321.GA13664@w540> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "A.S. Dong" Cc: 'jmondi' , "'linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org'" , 'Mark Rutland' , "'devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'" , Andy Duan , Jacky Bai , "'stefan-XLVq0VzYD2Y@public.gmane.org'" , "'linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org'" , 'Rob Herring' , "'kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org'" , "'linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org'" List-Id: devicetree@vger.kernel.org On Thu, May 25, 2017 at 05:06:56AM +0000, A.S. Dong wrote: > > > > +=== Pin Configuration Node === > > > > +- pins: One integers array, represents a group of pins mux setting. > > > > + The format is fsl,pins = , PIN_FUNC_ID is a pin > > > > +working > > > on > > > > + a specific function. > > > > + > > > > + NOTE: i.MX7ULP PIN_FUNC_ID consists of 4 integers as it shares one > > > mux > > > > + and config register as follows: > > > > + > > > > > > As your PIN_FUNC_ID specifies both the pin ids and their mux settings, > > > shouldn't you use the newly documented 'pinmux' property in place of > > > 'pins'? > > > > > > Please see > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/com > > > mit/ ?id=8d5e7c5df0a6c442373628be5221321172b1badf > > > > > > The current documentation specifies pin ids and mux settings have to > > > be assembled in one single integer, which is not your case, but that > > > can be changed to make it accept an array of integers values if needed. > > > > > > > Thanks for the info. > > Looks good to me. > > > > Shawn & Linus, > > Are you okay with this? > > > > If yes, I can extend the standard 'pinmux' property to support integer > > array and renew the patch series to use it. > > > > Would you comment on this question? > > Then I can decide whether sent a new series based on it. I'm fine with it. But what's important is whether Linus is fine with extending the standard 'pinmux' property to cover IMX case. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html