From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Date: Thu, 25 May 2017 16:20:32 +0800 Message-ID: <20170525082030.GB26102@dragon> References: <20170522131010.3537-1-nikita.yoush@cogentembedded.com> <20170525070007.GU26102@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nikita Yushchenko Cc: Sascha Hauer , Stefan Agner , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Cameron , Chris Healy , Jeff White List-Id: devicetree@vger.kernel.org On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote: > >> +&edma1 { > >> + status = "okay"; > >> +}; > >> + > >> +&dspi2 { > > > > Please keep these labelled nodes sort alphabetically. > > Ok > > >> + bus-num = <1>; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_dspi2>; > >> + status = "okay"; > > > > We usually have 'status' line at the bottom of property list. > > Ok > > >> + spi-num-chipselects = <2>; > >> + > >> + hi8435@1 { > > > > Node name should be something generic, while label can be specific > > model name. The following form might be better. > > > > hi8435: sensor@1 > > Ok > > Although the same file, in lines nearby, has m25p128@0 and at93c46d@1. It seems that I need more eyes to help review. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html