From: Tony Lindgren <tony@atomide.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: "Marek Vasut" <marex@denx.de>,
devicetree@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org,
"Frank Rowand" <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 2/5] ARM: dts: am335x-baltos: use IRQ_TYPE_* to specify irq flags
Date: Wed, 31 May 2017 10:19:32 -0700 [thread overview]
Message-ID: <20170531171932.GH3730@atomide.com> (raw)
In-Reply-To: <20170526180609.2699-2-uwe@kleine-koenig.org>
* Uwe Kleine-König <uwe@kleine-koenig.org> [170526 11:09]:
> According to the binding documentation and the source code the omap-gpio
> controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*.
>
> This patch uses the right variable type which yields the same result
> when compiled. Note that this might be wrong and actually
> IRQ_TYPE_LEVEL_LOW is intended by the dt author.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> Hello,
>
> can somebody with the hardware or it's documentation please check which
> flag is the right one?
I'll wait on this one until we have somebody test it.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-05-31 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 18:06 [PATCH 1/5] dts: gpio_atmel: adapt binding doc to reality Uwe Kleine-König
[not found] ` <20170526180609.2699-1-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
2017-05-26 18:06 ` [PATCH RFC 2/5] ARM: dts: am335x-baltos: use IRQ_TYPE_* to specify irq flags Uwe Kleine-König
2017-05-31 17:19 ` Tony Lindgren [this message]
2017-05-31 17:22 ` Yegor Yefremov
[not found] ` <CAGm1_ktJp+3t9ExuFJhKTmbM63yt-82PGP26KkEHGqK-tnfWRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-06 14:33 ` Yegor Yefremov
[not found] ` <CAGm1_kuKxVOetzMLdnVO+xQ7egX+paqOHLS+ckz6nFwKD5QBuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-12 7:32 ` Tony Lindgren
2017-05-26 18:06 ` [PATCH RFC 3/5] ARM: dts: at91-sama5d4: " Uwe Kleine-König
2017-05-26 19:17 ` Marek Vasut
[not found] ` <8bbb5802-518b-6ae1-6ea2-642b1f0b3d2e-ynQEQJNshbs@public.gmane.org>
2017-05-31 9:52 ` Alexandre Belloni
2017-05-26 18:06 ` [PATCH RFC 4/5] ARM: dts: tegra: " Uwe Kleine-König
2017-05-26 18:06 ` [PATCH RFC 5/5] ARM: dts: vf-colibri-eval: " Uwe Kleine-König
[not found] ` <20170526180609.2699-5-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org>
2017-06-04 3:49 ` Shawn Guo
2017-06-05 2:17 ` Stefan Agner
2017-05-26 18:52 ` [PATCH 1/5] dts: gpio_atmel: adapt binding doc to reality Andrew Lunn
2017-05-26 19:07 ` [PATCH v2 " Uwe Kleine-König
[not found] ` <20170526190703.t5fab33peh2cmobm-T6qyLwKrzP+Pq0V0m3QNwQq/OYV65a7L4Y2cMoPwMik@public.gmane.org>
2017-05-31 9:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531171932.GH3730@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).