devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Daniel Mack <daniel@zonque.org>, Rob Herring <robh@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	sebastian.reichel@collabora.co.uk
Subject: Re: [RFC v2 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors
Date: Wed, 31 May 2017 19:37:18 +0200	[thread overview]
Message-ID: <20170531173718.GA11983@amd> (raw)
In-Reply-To: <20170529130524.GF29527@valkosipuli.retiisi.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

Hi!

> > I agree, yes. I think the only way to solve this is to have a generic
> > EEPROM API that allows the camera sensor to read data from it. If
> 
> We have one already, and it's defined in Documentation/misc-devices/eeprom .
> 
> > another vendor uses a different type of EEPROM, the sensor driver would
> > remain the same, as it only reads data from the storage behind the
> > phandle, not caring about the details.
> > 
> > Same goes for the lens driver, and after thinking about it for awhile,
> > I'd say it makes most sense to allow referencing a v4l2_subdev device
> > through a phandle from another v4l2_subdev, and then offload certain
> > commands such as V4L2_CID_FOCUS_ABSOLUTE to the device that does the
> > actual work. Opinions?
> 
> There are different kinds of lens systems and I don't think the sensor
> drivers should be aware of them. The current approach is that the lens is a
> separate sub-device --- the intent of the patchset I posted was to document
> how the information on the related lens and eeprom components is conveyed to
> the software. There's one such driver in the mainline kernel, ad5820.
> 
> Unfortunately we don't right now have a good user space interface for
> telling which sensor a lens device is related to. The struct
> media_entity_desc does have a group_id field for grouping the sub-devices
> but that's hardly a good way to describe this.

Yeah, it would be good to get the corresponding patches to be merged
to v4l-utils...

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-05-31 17:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05  8:48 [RFC v2 0/3] Document bindings for camera modules and associated flash devices Sakari Ailus
     [not found] ` <1493974110-26510-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-05  8:48   ` [RFC v2 1/3] dt: bindings: Add a binding for flash devices associated to a sensor Sakari Ailus
     [not found]     ` <1493974110-26510-2-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-08 17:13       ` Rob Herring
2017-05-05  8:48   ` [RFC v2 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors Sakari Ailus
     [not found]     ` <1493974110-26510-4-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-05  9:10       ` Sebastian Reichel
2017-05-08 17:24     ` Rob Herring
2017-05-29 12:20       ` Sakari Ailus
2017-05-29 12:39         ` Daniel Mack
     [not found]           ` <c7a98681-4c95-0103-96ee-97ca6a02d9b3-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2017-05-29 13:05             ` Sakari Ailus
2017-05-31 17:37               ` Pavel Machek [this message]
2017-06-01  8:00                 ` Sakari Ailus
2017-05-05  8:48 ` [RFC v2 2/3] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
     [not found]   ` <1493974110-26510-3-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-05  9:09     ` Sebastian Reichel
2017-05-08 17:14     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170531173718.GA11983@amd \
    --to=pavel@ucw.cz \
    --cc=daniel@zonque.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@iki.fi \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sebastian.reichel@collabora.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).