Re: [PATCH 1/2] drm/bridge: Add Cadence DSI driver

From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: kbuild test robot <lkp@intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Cyprian Wronka <cwronka@cadence.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Simon Hatliff <hatliff@cadence.com>,
	dri-devel@lists.freedesktop.org,
	Richard Sproul <sproul@cadence.com>,
	Alan Douglas <adouglas@cadence.com>,
	Rob Herring <robh+dt@kernel.org>,
	kbuild-all@01.org, Kumar Gala <galak@codeaurora.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Neil Webb <neilw@cadence.com>
Subject: Re: [PATCH 1/2] drm/bridge: Add Cadence DSI driver
Date: Fri, 2 Jun 2017 14:02:57 +0200	[thread overview]
Message-ID: <20170602140257.5e0524fa@bbrezillon> (raw)
In-Reply-To: <201706021924.1vwA2TOY%fengguang.wu@intel.com>

On Fri, 2 Jun 2017 19:07:28 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi Boris,
> 
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on v4.12-rc3 next-20170602]
> [cannot apply to drm/drm-next drm-intel/for-linux-next]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-Add-Cadence-DSI-driver/20170602-162006
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_attach':
> >> drivers/gpu/drm/bridge/cdns-dsi.c:550:27: error: passing argument 1 of 'drm_bridge_attach' from incompatible pointer type [-Werror=incompatible-pointer-types]  
>       ret = drm_bridge_attach(bridge->dev, output->bridge);
>                               ^~~~~~
>    In file included from include/drm/drm_crtc.h:43:0,
>                     from include/drm/drm_atomic_helper.h:31,
>                     from drivers/gpu/drm/bridge/cdns-dsi.c:19:
>    include/drm/drm_bridge.h:210:5: note: expected 'struct drm_encoder *' but argument is of type 'struct drm_device *'
>     int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
>         ^~~~~~~~~~~~~~~~~
> >> drivers/gpu/drm/bridge/cdns-dsi.c:550:9: error: too few arguments to function 'drm_bridge_attach'  
>       ret = drm_bridge_attach(bridge->dev, output->bridge);
>             ^~~~~~~~~~~~~~~~~
>    In file included from include/drm/drm_crtc.h:43:0,
>                     from include/drm/drm_atomic_helper.h:31,
>                     from drivers/gpu/drm/bridge/cdns-dsi.c:19:
>    include/drm/drm_bridge.h:210:5: note: declared here
>     int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
>         ^~~~~~~~~~~~~~~~~
>    drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_detach':
> >> drivers/gpu/drm/bridge/cdns-dsi.c:566:3: error: implicit declaration of function 'drm_bridge_detach' [-Werror=implicit-function-declaration]  
>       drm_bridge_detach(output->bridge);
>       ^~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> coccinelle warnings: (new ones prefixed by >>)
> 
> >> drivers/gpu/drm/bridge/cdns-dsi.c:980:5-11: inconsistent IS_ERR and PTR_ERR on line 981.  
> 
> Please review and possibly fold the followup patch.
> 
> vim +/drm_bridge_attach +550 drivers/gpu/drm/bridge/cdns-dsi.c

Oops. Forgot to rebase on a v4.12-rc1 before sending the patches. I'll
a send new version fixing these errors.

Sorry for the noise.

Boris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel