Re: [PATCH 1/2] drm/bridge: Add Cadence DSI driver

[kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3499 bytes --]

Hi Boris,

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.12-rc3 next-20170602]
[cannot apply to drm/drm-next drm-intel/for-linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-Add-Cadence-DSI-driver/20170602-162006
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_attach':
>> drivers/gpu/drm/bridge/cdns-dsi.c:550:27: error: passing argument 1 of 'drm_bridge_attach' from incompatible pointer type [-Werror=incompatible-pointer-types]
      ret = drm_bridge_attach(bridge->dev, output->bridge);
                              ^~~~~~
   In file included from include/drm/drm_crtc.h:43:0,
                    from include/drm/drm_atomic_helper.h:31,
                    from drivers/gpu/drm/bridge/cdns-dsi.c:19:
   include/drm/drm_bridge.h:210:5: note: expected 'struct drm_encoder *' but argument is of type 'struct drm_device *'
    int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
        ^~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/bridge/cdns-dsi.c:550:9: error: too few arguments to function 'drm_bridge_attach'
      ret = drm_bridge_attach(bridge->dev, output->bridge);
            ^~~~~~~~~~~~~~~~~
   In file included from include/drm/drm_crtc.h:43:0,
                    from include/drm/drm_atomic_helper.h:31,
                    from drivers/gpu/drm/bridge/cdns-dsi.c:19:
   include/drm/drm_bridge.h:210:5: note: declared here
    int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
        ^~~~~~~~~~~~~~~~~
   drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_detach':
>> drivers/gpu/drm/bridge/cdns-dsi.c:566:3: error: implicit declaration of function 'drm_bridge_detach' [-Werror=implicit-function-declaration]
      drm_bridge_detach(output->bridge);
      ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/bridge/cdns-dsi.c:980:5-11: inconsistent IS_ERR and PTR_ERR on line 981.

Please review and possibly fold the followup patch.

vim +/drm_bridge_attach +550 drivers/gpu/drm/bridge/cdns-dsi.c

   544		case CDNS_DSI_PANEL:
   545			ret = cdns_dsi_output_attach_panel(output);
   546			break;
   547	
   548		case CDNS_DSI_BRIDGE:
   549			output->bridge->encoder = bridge->encoder;
 > 550			ret = drm_bridge_attach(bridge->dev, output->bridge);
   551			break;
   552	
   553		default:
   554			ret = -ENOTSUPP;
   555		}
   556	
   557		return ret;
   558	}
   559	
   560	static void cdns_dsi_bridge_detach(struct drm_bridge *bridge)
   561	{
   562		struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
   563		struct cdns_dsi_output *output = input->dsi->output;
   564	
   565		if (output->type == CDNS_DSI_BRIDGE && output->bridge->dev)
 > 566			drm_bridge_detach(output->bridge);
   567	}
   568	
   569	static bool cdns_dsi_bridge_mode_fixup(struct drm_bridge *bridge,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60109 bytes --]