From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Rosin <peda@lysator.liu.se>
Cc: linux-kernel@vger.kernel.org, Peter Rosin <peda@axentia.se>,
Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jonathan Corbet <corbet@lwn.net>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-doc@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Colin Ian King <colin.king@canonical.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
kernel@pengutronix.de
Subject: Re: [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes
Date: Sat, 3 Jun 2017 19:31:21 +0900 [thread overview]
Message-ID: <20170603103121.GA9599@kroah.com> (raw)
In-Reply-To: <20170603102627.GA24274@kroah.com>
On Sat, Jun 03, 2017 at 07:26:27PM +0900, Greg Kroah-Hartman wrote:
> On Sun, May 14, 2017 at 09:51:03PM +0200, Peter Rosin wrote:
> > From: Peter Rosin <peda@axentia.se>
> >
> > Hi Greg,
> >
> > Philipp found problems in v14 with using a mutex for locking that was
> > the outcome of the review for v13, so I'm now using a semaphore instead
> > of the rwsem that was in v13. That at least got rid of the scary call
> > to downgrade_write. However, I'm still unsure about what you actually
> > meant with your comment about lack of sparse markings [1]. I did add
> > __must_check to the funcs that selects the mux, but I've got this
> > feeling that this is not what you meant?
>
> I thought there was a way to mark a function as requiring a lock be held
> when it is being called. Does sparse not support that anymore?
Anyway, not a big deal. I still worry about the calls blocking when
people are not expecting them to, but it is just the nature of th api I
guess.
All now queued up, nice work, thanks for sticking with this.
greg k-h
next prev parent reply other threads:[~2017-06-03 10:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 19:51 [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes Peter Rosin
2017-05-14 19:51 ` [PATCH v15 01/13] devres: trivial whitespace fix Peter Rosin
2017-05-14 19:51 ` [PATCH v15 02/13] dt-bindings: document devicetree bindings for mux-controllers and gpio-mux Peter Rosin
2017-05-14 19:51 ` [PATCH v15 03/13] mux: minimal mux subsystem Peter Rosin
2017-05-17 9:38 ` Philipp Zabel
2017-05-14 19:51 ` [PATCH v15 04/13] mux: gpio: add mux controller driver for gpio based multiplexers Peter Rosin
2017-05-17 9:38 ` Philipp Zabel
2017-05-14 19:51 ` [PATCH v15 05/13] iio: inkern: api for manipulating ext_info of iio channels Peter Rosin
2017-05-14 19:51 ` [PATCH v15 06/13] dt-bindings: iio: io-channel-mux: document io-channel-mux bindings Peter Rosin
2017-05-14 19:51 ` [PATCH v15 07/13] iio: multiplexer: new iio category and iio-mux driver Peter Rosin
2017-05-14 19:51 ` [PATCH v15 08/13] dt-bindings: i2c: i2c-mux: document general purpose i2c-mux bindings Peter Rosin
2017-05-14 19:51 ` [PATCH v15 09/13] i2c: i2c-mux-gpmux: new driver Peter Rosin
2017-05-14 19:51 ` [PATCH v15 10/13] dt-bindings: mux-adg792a: document devicetree bindings for ADG792A/G mux Peter Rosin
2017-05-14 19:51 ` [PATCH v15 11/13] mux: adg792a: add mux controller driver for ADG792A/G Peter Rosin
2017-05-14 19:51 ` [PATCH v15 12/13] dt-bindings: add mmio-based syscon mux controller DT bindings Peter Rosin
2017-05-14 19:51 ` [PATCH v15 13/13] mux: mmio-based syscon mux controller Peter Rosin
2017-06-03 10:26 ` [PATCH v15 00/13] mux controller abstraction and iio/i2c muxes Greg Kroah-Hartman
2017-06-03 10:31 ` Greg Kroah-Hartman [this message]
2017-06-03 21:37 ` Peter Rosin
2017-06-04 7:46 ` Wolfram Sang
2017-06-03 18:37 ` Luc Van Oostenryck
2017-06-03 19:34 ` Greg Kroah-Hartman
2017-06-03 20:26 ` Luc Van Oostenryck
2017-06-03 21:29 ` Peter Rosin
[not found] ` <c6db1b4b-5bf2-96e8-a4fc-f5932c660b18-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2017-06-03 22:21 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603103121.GA9599@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.gortmaker@windriver.com \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).