From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH RFC 5/5] ARM: dts: vf-colibri-eval: use IRQ_TYPE_* to specify irq flags Date: Sun, 4 Jun 2017 11:49:03 +0800 Message-ID: <20170604034902.GC4094@dragon> References: <20170526180609.2699-1-uwe@kleine-koenig.org> <20170526180609.2699-5-uwe@kleine-koenig.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170526180609.2699-5-uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Stefan Agner Cc: Rob Herring , Frank Rowand , Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Marek Vasut , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, May 26, 2017 at 08:06:09PM +0200, Uwe Kleine-König wrote: > According to the binding documentation and the source code the > vf610-gpio controller takes IRQ_TYPE_* as its flags values, not > GPIO_ACTIVE_*. > > This patch uses the right variable type which yields the same result > when compiled. Note that this might be wrong and actually > IRQ_TYPE_LEVEL_LOW is intended by the dt author. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > can somebody with the hardware or it's documentation please check which > flag is the right one? @Stefan, can you help to confirm? Shawn > > Best regards > Uwe > > arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > index 091b738041a0..3e0c84d79c43 100644 > --- a/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > +++ b/arch/arm/boot/dts/vf-colibri-eval-v3.dtsi > @@ -117,7 +117,7 @@ > clocks = <&clk16m>; > spi-max-frequency = <10000000>; > interrupt-parent = <&gpio1>; > - interrupts = <11 GPIO_ACTIVE_LOW>; > + interrupts = <11 IRQ_TYPE_EDGE_RISING>; > }; > }; > > -- > 2.11.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html