Re: [PATCH V2 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module

[Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

Hi!

> Generally I came to a conclusion that it will be best to register
> additional LED RGB class device in an addition to three LED class
> devices representing each color. In order to avoid hard to solve
> locking problems I propose to allow for simultaneous access to LED
> class devices and LED RGB class device gathering them.
> 
> All in all, currently we also don't give an exclusive access to
> a particular LED class device, which always can lead to overwriting
> current brightness by another process. These issues must be arbitrated
> by user space.
> 
> I propose that LED RGB class device exposed following files:
> 
> - red_brightness
> - green_brightness
> - blue_brightness
> - latch_color

Actually, I'd just do single file, "rgb_brightness" with 3
values. Overhead of writing 3 values is pretty much 0.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]