From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 2/8] mfd: hi6421-pmic: cleanup: update dev_err messages Date: Tue, 6 Jun 2017 14:50:17 +0100 Message-ID: <20170606135017.gwdyrcof5iqvtlw5@dell> References: <20170606085143.13154-1-guodong.xu@linaro.org> <20170606085143.13154-3-guodong.xu@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170606085143.13154-3-guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guodong Xu Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org, riku.voipio-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org, damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org, ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, hw.wangxiaoyin-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 06 Jun 2017, Guodong Xu wrote: > Update dev_err messages to make them more readable. > > Signed-off-by: Guodong Xu > --- > drivers/mfd/hi6421-pmic-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c > index ad9e3d8..b1139d4 100644 > --- a/drivers/mfd/hi6421-pmic-core.c > +++ b/drivers/mfd/hi6421-pmic-core.c > @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base, > &hi6421_regmap_config); > if (IS_ERR(pmic->regmap)) { > - dev_err(&pdev->dev, > - "regmap init failed: %ld\n", PTR_ERR(pmic->regmap)); > + dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n", > + PTR_ERR(pmic->regmap)); > return PTR_ERR(pmic->regmap); > } > > @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs, > ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); > if (ret) { > - dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret); > + dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret); > return ret; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html