From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1 Date: Wed, 7 Jun 2017 11:43:43 +0200 Message-ID: <20170607094343.qqiwnu2mhmoi6jn7@flea.lan> References: <20170604160149.30230-1-icenowy@aosc.io> <20170604160149.30230-5-icenowy@aosc.io> <3642057.oKT9kIlu8M@jernej-laptop> <493AC6F2-3CB3-48F5-9568-A34AA927238F@aosc.io> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="u4bgzgql5drlytxk" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <493AC6F2-3CB3-48F5-9568-A34AA927238F-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Jernej =?utf-8?Q?=C5=A0krabec?= , Rob Herring , Chen-Yu Tsai , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Icenowy Zheng List-Id: devicetree@vger.kernel.org --u4bgzgql5drlytxk Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote: > >You should also expand function sun4i_drv_node_is_tcon() at sun4i_drv.c > >with > >new entries, but I'm not sure if this fits in this patch. > > Instead I think it should be renamed to something like > "sun4i_drv_node_is_tcon_with_ch0". I'm not sure, or at least, it shouldn't make any difference, since TCON without a channel 0 will not have an endpoint 0, so this will be dealt with already. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --u4bgzgql5drlytxk--