From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Andrzej Hajda <a.hajda@samsung.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 9/9] ARM: dts: exynos: add needs-hpd to &hdmicec for Odroid-U3
Date: Wed, 7 Jun 2017 20:36:45 +0200 [thread overview]
Message-ID: <20170607183645.tsjj3mb2k6fdnoei@kozik-lap> (raw)
In-Reply-To: <20170607144616.15247-10-hverkuil@xs4all.nl>
On Wed, Jun 07, 2017 at 04:46:16PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> The Odroid-U3 board has an IP4791CZ12 level shifter that is
> disabled if the HPD is low, which means that the CEC pin is
> disabled as well.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Andrzej Hajda <a.hajda@samsung.com>
> Cc: devicetree@vger.kernel.org
> ---
> arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> index 7504a5aa538e..7209cb48fc2a 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
> @@ -131,3 +131,7 @@
> cs-gpios = <&gpb 5 GPIO_ACTIVE_HIGH>;
> status = "okay";
> };
> +
> +&hdmicec {
> + needs-hpd;
> +};
All good, except we try to keep them sorted alphabetically (helps
avoiding conflicts and makes things easier to find)... which for this
particular file will be difficult as it is semi-sorted. :)
Anyway, how about putting this new node after &buck?
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-06-07 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170607144616.15247-1-hverkuil@xs4all.nl>
2017-06-07 14:46 ` [PATCH 7/9] dt-bindings: media/s5p-cec.txt: document needs-hpd property Hans Verkuil
2017-06-09 14:07 ` Rob Herring
2017-06-09 14:11 ` Hans Verkuil
2017-06-09 15:31 ` Rob Herring
2017-06-09 15:55 ` Hans Verkuil
[not found] ` <8e6ed9b6-5b4b-8650-2c92-47a593e73d94-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2017-06-09 16:46 ` Rob Herring
2017-06-07 14:46 ` [PATCH 8/9] s5p_cec: set the CEC_CAP_NEEDS_HPD flag if needed Hans Verkuil
[not found] ` <CGME20170612124120epcas1p3ef17f5a1f6f71c00757d4f3ee283ffc8@epcas1p3.samsung.com>
[not found] ` <20170607144616.15247-9-hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
2017-06-12 12:41 ` Sylwester Nawrocki
2017-06-07 14:46 ` [PATCH 9/9] ARM: dts: exynos: add needs-hpd to &hdmicec for Odroid-U3 Hans Verkuil
2017-06-07 18:36 ` Krzysztof Kozlowski [this message]
2017-06-07 18:59 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607183645.tsjj3mb2k6fdnoei@kozik-lap \
--to=krzk@kernel.org \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox