From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Eugen Hristev <eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
Cc: nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland
<mark.rutland-5wv7dgnIgG8@public.gmane.org>devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 2/4] Documentation: dt: iio: at91-sama5d2_adc: add hw trigger edge binding
Date: Sun, 11 Jun 2017 12:24:13 +0100 [thread overview]
Message-ID: <20170611122413.20008d30@kernel.org> (raw)
In-Reply-To: <1496992039-17964-3-git-send-email-eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
On Fri, 9 Jun 2017 10:07:17 +0300
Eugen Hristev <eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> wrote:
> Add property for the edge type of the hardware trigger pin ADTRG
>
> Signed-off-by: Eugen Hristev <eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
Hi Eugen,
CC the device tree maintainers and list for devicetree binding changes.
I've added them. This one is unusual enough it will need and Ack from
that direction (and I prefer to get them even for the trivial patches
when Rob and Mark aren't too busy!)
Jonathan
> ---
> Changes in v4:
> - Modified bindings to be similar with interrupts
>
> Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> index 3223684..552e7a8 100644
> --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> @@ -11,6 +11,11 @@ Required properties:
> - atmel,min-sample-rate-hz: Minimum sampling rate, it depends on SoC.
> - atmel,max-sample-rate-hz: Maximum sampling rate, it depends on SoC.
> - atmel,startup-time-ms: Startup time expressed in ms, it depends on SoC.
> + - atmel,trigger-edge-type: One of possible edge types for the ADTRG hardware
> + trigger pin. When the specific edge type is detected, the conversion will
> + start. Possible values are rising, falling, or both.
> + This property uses the IRQ edge types values: IRQ_TYPE_EDGE_RISING ,
> + IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_BOTH
>
> Example:
>
> @@ -25,4 +30,5 @@ adc: adc@fc030000 {
> atmel,startup-time-ms = <4>;
> vddana-supply = <&vdd_3v3_lp_reg>;
> vref-supply = <&vdd_3v3_lp_reg>;
> + atmel,trigger-edge-type = <IRQ_TYPE_EDGE_BOTH>;
> }
next prev parent reply other threads:[~2017-06-11 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 7:07 [PATCH v4 0/4] iio: adc: sama5d2_adc hw triggers and buffers Eugen Hristev
2017-06-09 7:07 ` [PATCH v4 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin Eugen Hristev
2017-06-09 7:07 ` [PATCH v4 2/4] Documentation: dt: iio: at91-sama5d2_adc: add hw trigger edge binding Eugen Hristev
[not found] ` <1496992039-17964-3-git-send-email-eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-06-11 11:24 ` Jonathan Cameron [this message]
[not found] ` <20170611122413.20008d30-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-11 11:25 ` Jonathan Cameron
2017-06-14 15:30 ` Rob Herring
2017-06-09 7:07 ` [PATCH v4 3/4] ARM: dts: at91: sama5d2: add ADC hw trigger edge type Eugen Hristev
2017-06-09 7:07 ` [PATCH v4 4/4] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support Eugen Hristev
[not found] ` <1496992039-17964-5-git-send-email-eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-06-11 11:34 ` Jonathan Cameron
[not found] ` <1496992039-17964-1-git-send-email-eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-06-14 6:57 ` [PATCH v4 0/4] iio: adc: sama5d2_adc hw triggers and buffers Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170611122413.20008d30@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eugen.hristev-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).