Re: [PATCH] dt-bindings: power: supply: cpcap-battery: Add power-supplies property

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

Hi,

On Mon, Jun 12, 2017 at 12:20:25AM -0700, Tony Lindgren wrote:
> The binding for cpcap-battery is missing the standard power-supplies
> property as noted by Sebastian Reichel <sebastian.reichel@collabora.co.uk>.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  Documentation/devicetree/bindings/power/supply/cpcap-battery.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> --- a/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/cpcap-battery.txt
> @@ -8,6 +8,7 @@ Required properties:
>  - io-channels: IIO ADC channel specifier for each name in io-channel-names
>  - io-channel-names: Should contain the following entries:
>  		    "battdetb", "battp", "chg_isense", "batti"
> +- power-supplies: List of devices that supply power, typically cpcap_charger

This is missing the info, that its about phandles. Maybe:

- power-supplies: List of phandles for power-supplying devices, as
                  described in power_supply.txt. Typically a reference
                  to cpcap_charger.

-- Sebastian

>  
>  Example:
>  
> @@ -24,4 +25,5 @@ cpcap_battery: battery {
>  		       &cpcap_adc 5 &cpcap_adc 6>;
>  	io-channel-names = "battdetb", "battp",
>  			   "chg_isense", "batti";
> +	power-supplies = <&cpcap_charger>;
>  };
> -- 
> 2.13.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]