Re: [PATCH 6/8] leds: as3645a: Add LED flash class driver

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]

Krasny den!

> > > Thanks for the review!
> > 
> > You are welcome :-).
> > 
> > > On Wed, Jun 14, 2017 at 11:39:41PM +0200, Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > > From: Sakari Ailus <sakari.ailus@iki.fi>
> > > > 
> > > > That address no longer works, right?
> > > 
> > > Why wouldn't it work? Or... do you know something I don't? :-)
> > 
> > Aha. I thought I was removing it from source files because it was no
> > longer working, but maybe I'm misremembering? 
> 
> That was probably my @maxwell.research.nokia.com address. :-) There are no
> occurrences of that in the kernel source anymore.

I guess it probably was someone else using @iki.fi address, and I am
confused.

> > > > > +	struct v4l2_flash_config cfg = {
> > > > > +		.torch_intensity = {
> > > > > +			.min = AS_TORCH_INTENSITY_MIN,
> > > > > +			.max = flash->cfg.assist_max_ua,
> > > > > +			.step = AS_TORCH_INTENSITY_STEP,
> > > > > +			.val = flash->cfg.assist_max_ua,
> > > > > +		},
> > > > > +		.indicator_intensity = {
> > > > > +			.min = AS_INDICATOR_INTENSITY_MIN,
> > > > > +			.max = flash->cfg.indicator_max_ua,
> > > > > +			.step = AS_INDICATOR_INTENSITY_STEP,
> > > > > +			.val = flash->cfg.indicator_max_ua,
> > > > > +		},
> > > > > +	};
> > > > 
> > > > Ugh. And here you have copy of the above struct, + .val. Can it be
> > > > somehow de-duplicated?
> > > 
> > > The flash_brightness_set callback uses micro-Amps as the unit and the driver
> > > needs to convert that to its own specific units. Yeah, there would be
> > > probably an easier way, too. But that'd likely require changes to the LED
> > > flash class.
> > 
> > Can as3645a_current_to_reg just access struct v4l2_flash_config so
> > that it does not have to recreate its look-alike on the fly?
> 
> struct v4l2_flash_config is only needed as an argument for
> v4l2_flash_init(). I'll split that into two functions in this occasion,
> it'll be nicer.
> 
> We now have more or less the same conversion implemented in three or so
> times, there have to be ways to make that easier for drivers. I think that
> could be done later, as well as adding support for checking the flash
> strobe status.

Ok, thanks!
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]