From: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>,
Javier Martinez Canillas
<javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
Subject: [RESEND PATCH v6 3/8] mfd: retu: Add OF device ID table
Date: Thu, 15 Jun 2017 20:49:23 +0200 [thread overview]
Message-ID: <20170615184928.12007-4-javier@dowhile0.org> (raw)
In-Reply-To: <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have a
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Reviewed-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
Changes in v6:
- Add Wolfram Sang's Reviewed-by tag.
Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>'s Acked-by tag.
- Add Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>'s Acked-by tag.
Changes in v4:
- Drop -mfd suffix in compatible string (Lee Jones).
Changes in v3:
- Add a vendor prefix to the compatible string (Rob Herring).
Changes in v2:
- Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
drivers/mfd/retu-mfd.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
index 53e1d386d2c0..e7d27b7861c1 100644
--- a/drivers/mfd/retu-mfd.c
+++ b/drivers/mfd/retu-mfd.c
@@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
};
MODULE_DEVICE_TABLE(i2c, retu_id);
+static const struct of_device_id retu_of_match[] = {
+ { .compatible = "nokia,retu" },
+ { .compatible = "nokia,tahvo" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, retu_of_match);
+
static struct i2c_driver retu_driver = {
.driver = {
.name = "retu-mfd",
+ .of_match_table = retu_of_match,
},
.probe = retu_probe,
.remove = retu_remove,
--
2.9.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-15 18:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 18:49 [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-06-15 18:49 ` [RESEND PATCH v6 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Javier Martinez Canillas
2017-06-15 18:49 ` [RESEND PATCH v6 2/8] mfd: retu: Drop -mfd suffix from I2C device ID name Javier Martinez Canillas
[not found] ` <20170615184928.12007-3-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
2017-06-19 14:54 ` Lee Jones
2017-06-28 7:30 ` Javier Martinez Canillas
2017-06-15 18:49 ` [RESEND PATCH v6 4/8] ARM: dts: n8x0: Add vendor prefix to retu node Javier Martinez Canillas
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
2017-06-15 18:49 ` Javier Martinez Canillas [this message]
2017-06-15 18:49 ` [RESEND PATCH v6 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas
2017-06-15 18:49 ` [RESEND PATCH v6 6/8] dt-bindings: mfd: Add TI tps6105x chip bindings Javier Martinez Canillas
[not found] ` <20170615184928.12007-7-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
2017-07-10 8:08 ` Lee Jones
2017-06-15 18:49 ` [RESEND PATCH v6 7/8] mfd: tps6105x: Add OF device ID table Javier Martinez Canillas
2017-06-15 18:49 ` [RESEND PATCH v6 8/8] ARM: ux500: Add vendor prefix to tps61052 node Javier Martinez Canillas
2017-07-10 7:40 ` [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-07-10 8:07 ` Lee Jones
2017-07-10 8:34 ` Javier Martinez Canillas
2017-07-18 8:04 ` [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window Lee Jones
2017-07-27 12:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615184928.12007-4-javier@dowhile0.org \
--to=javier-0uqlzysmnqxg9huczpvpmw@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox