From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER Date: Mon, 19 Jun 2017 16:36:55 -0700 Message-ID: <20170619233655.GR20170@codeaurora.org> References: <1495428748-11153-1-git-send-email-leo.yan@linaro.org> <1495428748-11153-2-git-send-email-leo.yan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1495428748-11153-2-git-send-email-leo.yan@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Leo Yan Cc: Mark Rutland , devicetree@vger.kernel.org, Guodong Xu , Catalin Marinas , Michael Turquette , Will Deacon , linux-kernel@vger.kernel.org, Wei Xu , Rob Herring , Haojian Zhuang , Zhangfei Gao , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 05/22, Leo Yan wrote: > The timer will register into system at very early phase at kernel boot; > if timer needs to use clock, the clock should be get ready in function > of_clk_init() so later the timer driver probe can retrieve clock > successfully. This is finished in below flow on arm64: > > start_kernel() > `-> time_init() > `-> of_clk_init(NULL) => register timer's clock > `-> clocksource_probe() => register timer > > On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered > as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result, > sp804 timer probe returns failure due if cannot bind clock properly. > > To fix the failure, this patch is to split crgctrl clocks into two > subsets. One part is for fixed_rate_clks which includes pre-defined > fixed rate clocks, and "osc32k" clock is in this category; So we change > their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks > can be registered ahead with function of_clk_init() and timer driver can > bind timer clock successfully; the rest of the crgctrl clocks are still > registered by the probe of the platform driver. > > This patch also adds checking for all crgctrl clocks registration and > print out log if any clock has failure. > > Signed-off-by: Leo Yan > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project