From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
rafael@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
robh@kernel.org, ahs3@redhat.com, frowand.list@gmail.com,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v7.2 7/7] device property: Get rid of struct fwnode_handle type field
Date: Tue, 20 Jun 2017 15:03:34 +0300 [thread overview]
Message-ID: <20170620120334.GX629@lahna.fi.intel.com> (raw)
In-Reply-To: <1497948596-1009-1-git-send-email-sakari.ailus@linux.intel.com>
On Tue, Jun 20, 2017 at 11:49:56AM +0300, Sakari Ailus wrote:
> Instead of relying on the struct fwnode_handle type field, define
> fwnode_operations structs for all separate types of fwnodes. To find out
> the type, compare to the ops field to relevant ops structs.
>
> This change has two benefits:
>
> 1. it avoids adding the type field to each and every instance of struct
> fwnode_handle, thus saving memory and
>
> 2. makes the ops field the single factor that defines both the types of
> the fwnode as well as defines the implementation of its operations,
> decreasing the possibility of bugs when developing code dealing with
> fwnode internals.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-06-20 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 9:37 [PATCH v7 0/6] Move firmware specific code to firmware specific locations Sakari Ailus
2017-06-06 9:37 ` [PATCH v7 1/6] ACPI: Constify argument to acpi_device_is_present() Sakari Ailus
[not found] ` <1496741861-8240-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-06 9:37 ` [PATCH v7 2/6] device property: Move FW type specific functionality to FW specific files Sakari Ailus
2017-06-09 20:21 ` Rob Herring
2017-06-12 13:53 ` Sakari Ailus
2017-06-06 9:37 ` [PATCH v7 3/6] device property: Move fwnode graph ops to firmware specific locations Sakari Ailus
2017-06-06 9:37 ` [PATCH v7 4/6] device property: Introduce fwnode_device_is_available() Sakari Ailus
2017-06-06 9:37 ` [PATCH v7 5/6] device property: Add FW type agnostic fwnode_graph_get_remote_node Sakari Ailus
2017-06-06 9:37 ` [PATCH v7 6/6] device property: Add fwnode_graph_get_port_parent Sakari Ailus
2017-06-13 11:49 ` [PATCH v7.1 7/7] device property: Get rid of struct fwnode_handle type field Sakari Ailus
2017-06-18 6:58 ` Mika Westerberg
2017-06-20 8:51 ` Sakari Ailus
2017-06-20 8:49 ` [PATCH v7.2 " Sakari Ailus
2017-06-20 12:03 ` Mika Westerberg [this message]
2017-06-20 14:14 ` Lorenzo Pieralisi
2017-06-22 0:57 ` Rafael J. Wysocki
2017-06-22 10:29 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620120334.GX629@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ahs3@redhat.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-acpi@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).