From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K Date: Tue, 20 Jun 2017 17:36:51 +0200 Message-ID: <20170620173651.6370ea58@windsurf.lan> References: <20170620140722.31646-1-thomas.petazzoni@free-electrons.com> <20170620140722.31646-7-thomas.petazzoni@free-electrons.com> <87tw3a3dy4.fsf@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87tw3a3dy4.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gregory CLEMENT Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Nadav Haklai , Hanna Hawa , Yehuda Yitschak , Antoine Tenart , =?UTF-8?B?TWlxdcOobA==?= Raynal List-Id: devicetree@vger.kernel.org Hello, On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote: > > +#include > > With this line you created a dependency with the patch "irqchip: > irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is > not buidable. > > So either I wait for the next kernel release to apply it or I will need > a stable branch with the commit adding the mvebu-icu.h file. Alternatively, I could change the patch to use hardcoded values for now (i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during the next kernel cycle to use the #define value. I would really prefer such a solution to a solution where merging the entire ICU DT change would be delayed by one cycle. Let me know what you prefer. Maybe Marc can say if the irqchip maintainers can provide a stable branch containing the mvebu-icu.h file. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html