From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] dt-bindings: mtd: elm: Correct compatible string requirement Date: Thu, 22 Jun 2017 21:14:12 +0200 Message-ID: <20170622211412.2c9729ab@bbrezillon> References: <1498047726-31398-1-git-send-email-trini@konsulko.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1498047726-31398-1-git-send-email-trini-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tom Rini Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Cyrille Pitchen , Rob Herring , Mark Rutland List-Id: devicetree@vger.kernel.org On Wed, 21 Jun 2017 08:22:06 -0400 Tom Rini wrote: > The binding says that the compatible string must be "ti,am33xx-elm" > but the code checks only for, and all functioning users set, this as > "ti,am3352-elm" so correct the binding. > > Cc: David Woodhouse > Cc: Brian Norris > Cc: Boris Brezillon > Cc: Marek Vasut > Cc: Richard Weinberger > Cc: Cyrille Pitchen > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Tom Rini Applied. Thanks, Boris > --- > I have submitted a separate patch that correct the dm816x.dtsi to set > the compatible string there for the elm from ti,816-elm to ti,am3352-elm > and tested it on the hardware, where it works. It is quite likely that > dm814x.dtsi can be trivially corrected as it came after dm816x and > before am335x but as I cannot test the hardware, I did not update that. > --- > Documentation/devicetree/bindings/mtd/elm.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt > index 8c1528c421d4..59ddc61c1076 100644 > --- a/Documentation/devicetree/bindings/mtd/elm.txt > +++ b/Documentation/devicetree/bindings/mtd/elm.txt > @@ -1,7 +1,7 @@ > Error location module > > Required properties: > -- compatible: Must be "ti,am33xx-elm" > +- compatible: Must be "ti,am3352-elm" > - reg: physical base address and size of the registers map. > - interrupts: Interrupt number for the elm. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html