From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dongwoo Lee <dwoo08.lee@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
cw00.choi@samsung.com, andi.shyti@samsung.com
Subject: Re: [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node
Date: Sat, 24 Jun 2017 20:16:20 +0200 [thread overview]
Message-ID: <20170624181620.m3uve2p5mlfhrhss@kozik-lap> (raw)
In-Reply-To: <1497942745-8607-2-git-send-email-dwoo08.lee@samsung.com>
On Tue, Jun 20, 2017 at 04:12:23PM +0900, Dongwoo Lee wrote:
> Exynos5433 has two usb 3.0 controllers: usbhost and usbdrd. usbhost
> is host-only controller whereas usbdrd supports both peripheral and
> host mode. "drd" means dual-role device, so usbhost cannot be labeled
> with the name contains "drd". Howerver, the label usbdrd_dwc3_0 was
Patch looks okay but it is too late for current cycle so I will take it
for v4.14. In future, please run spell check :)
Best regards,
Krzysztof
> used for usbhost's dwc3 node. It seems it obviously fault because TM2
> and TM2E doesn't use usbhost but dr_mode property is assigned to it.
>
> This patch assigns the proper label for two dwc3 nodes, and apply
> changes to the related reference
>
> Signed-off-by: Dongwoo Lee <dwoo08.lee@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 804a270..477c3bc 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -1202,7 +1202,7 @@
> status = "okay";
> };
>
> -&usbdrd_dwc3_0 {
> +&usbdrd_dwc3 {
> dr_mode = "otg";
> };
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 727f36a..7fe994b 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1367,7 +1367,7 @@
> ranges;
> status = "disabled";
>
> - dwc3@15400000 {
> + usbdrd_dwc3: dwc3@15400000 {
> compatible = "snps,dwc3";
> reg = <0x15400000 0x10000>;
> interrupts = <GIC_SPI 231 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1414,7 +1414,7 @@
> ranges;
> status = "disabled";
>
> - usbdrd_dwc3_0: dwc3@15a00000 {
> + usbhost_dwc3: dwc3@15a00000 {
> compatible = "snps,dwc3";
> reg = <0x15a00000 0x10000>;
> interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>;
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-06-24 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170620071229epcas1p4076c72c941527ef3073e4036a7421cfb@epcas1p4.samsung.com>
2017-06-20 7:12 ` [PATCH 0/2] Enable USB dual-role operation for TM2 and TM2E Dongwoo Lee
2017-06-20 7:12 ` [PATCH 1/2] arm64: dts: exynos: Fix wrong label for USB 3.0 controller node Dongwoo Lee
2017-06-24 18:16 ` Krzysztof Kozlowski [this message]
2017-07-18 5:06 ` Krzysztof Kozlowski
[not found] ` <CGME20170620071232epcas1p44dcc6475c7f826a8da52ad776759a926@epcas1p4.samsung.com>
[not found] ` <1497942745-8607-1-git-send-email-dwoo08.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-06-20 7:12 ` [PATCH 2/2] arm64: dts: exynos: Add extcon property for TM2 and TM2E Dongwoo Lee
[not found] ` <1497942745-8607-3-git-send-email-dwoo08.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-07-18 5:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170624181620.m3uve2p5mlfhrhss@kozik-lap \
--to=krzk@kernel.org \
--cc=andi.shyti@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dwoo08.lee@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox