From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Lorenzo Bianconi
<lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lorenzo.bianconi-qxv4g6HH51o@public.gmane.org
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: support open drain mode
Date: Sun, 25 Jun 2017 17:03:31 +0100 [thread overview]
Message-ID: <20170625170331.6fcd73a5@kernel.org> (raw)
In-Reply-To: <20170621192129.10226-3-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org>
On Wed, 21 Jun 2017 21:21:29 +0200
Lorenzo Bianconi <lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi-qxv4g6HH51o@public.gmane.org>
Given this is a carbon copy of what we already have for the mpu3030 driver
I'm not going to waste Rob or Marks time pestering them for a review.
(obviously one is welcome if it happens to come along!)
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt b/Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt
> index 6f28ff55f3ec..1ff1af799c76 100644
> --- a/Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt
> +++ b/Documentation/devicetree/bindings/iio/imu/st_lsm6dsx.txt
> @@ -11,6 +11,14 @@ Required properties:
> Optional properties:
> - st,drdy-int-pin: the pin on the package that will be used to signal
> "data ready" (valid values: 1 or 2).
> +- drive-open-drain: the interrupt/data ready line will be configured
> + as open drain, which is useful if several sensors share the same
> + interrupt line. This is a boolean property.
> + (This binding is taken from pinctrl/pinctrl-bindings.txt)
> + If the requested interrupt is configured as IRQ_TYPE_LEVEL_HIGH or
> + IRQ_TYPE_EDGE_RISING a pull-down resistor is needed to drive the line
> + when it is not active, whereas a pull-up one is needed when interrupt
> + line is configured as IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_EDGE_FALLING.
> - interrupt-parent: should be the phandle for the interrupt controller
> - interrupts: interrupt mapping for IRQ. It should be configured with
> flags IRQ_TYPE_LEVEL_HIGH, IRQ_TYPE_EDGE_RISING, IRQ_TYPE_LEVEL_LOW or
next prev parent reply other threads:[~2017-06-25 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 19:21 [PATCH 0/2] Add open drain support to st_lsm6dsx Lorenzo Bianconi
[not found] ` <20170621192129.10226-1-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org>
2017-06-21 19:21 ` [PATCH 1/2] iio: imu: st_lsm6dsx: support open drain mode Lorenzo Bianconi
[not found] ` <20170621192129.10226-2-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org>
2017-06-24 20:08 ` Jonathan Cameron
[not found] ` <20170624210835.56ffdd1c-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-25 9:34 ` Lorenzo Bianconi
[not found] ` <CAA2SeNJ5yPqMiW2tVSc9ZSC5Rt=Q+CRoMibzigjvPyw05Qsr5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-25 16:01 ` Jonathan Cameron
2017-06-29 11:46 ` Linus Walleij
2017-06-21 19:21 ` [PATCH 2/2] dt-bindings: " Lorenzo Bianconi
[not found] ` <20170621192129.10226-3-lorenzo.bianconi-qxv4g6HH51o@public.gmane.org>
2017-06-25 16:03 ` Jonathan Cameron [this message]
2017-06-26 18:24 ` Rob Herring
2017-06-30 18:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170625170331.6fcd73a5@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.bianconi-qxv4g6HH51o@public.gmane.org \
--cc=lorenzo.bianconi83-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).