* [PATCH] ARM: dts: dra71-evm: mdio: Fix impedance values
@ 2017-06-21 8:45 Lokesh Vutla
[not found] ` <20170621084522.1828-1-lokeshvutla-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Lokesh Vutla @ 2017-06-21 8:45 UTC (permalink / raw)
To: Tony Lindgren, Device Tree Mailing List
Cc: Linux OMAP Mailing List, Rob Herring, Tero Kristo, Sekhar Nori,
Grygorii Strashko, Lokesh Vutla
v1 series[1] for dp83867 phy impedance-control support,
specifies to use ti,impedance-control with a value. These
properties got updated iduring review to specify whether
min or max impedance. But the DT still uses the old values
which never takes effect. Update the DT node by using the
proper DT properties.
[1] https://patchwork.kernel.org/patch/9239729/
Fixes: 9868bc585ae2c ("ARM: dts: Add support for dra718-evm")
Signed-off-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/dra71-evm.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index 4d57a55473af..a6298eb56978 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -190,7 +190,7 @@
ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
- ti,impedance-control = <0x1f>;
+ ti,min-output-impedance;
};
dp83867_1: ethernet-phy@3 {
@@ -198,7 +198,7 @@
ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
- ti,impedance-control = <0x1f>;
+ ti,min-output-impedance;
};
};
--
2.13.0
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: dra71-evm: mdio: Fix impedance values
[not found] ` <20170621084522.1828-1-lokeshvutla-l0cyMroinI0@public.gmane.org>
@ 2017-06-26 9:37 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2017-06-26 9:37 UTC (permalink / raw)
To: Lokesh Vutla
Cc: Device Tree Mailing List, Linux OMAP Mailing List, Rob Herring,
Tero Kristo, Sekhar Nori, Grygorii Strashko
* Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org> [170621 01:48]:
> v1 series[1] for dp83867 phy impedance-control support,
> specifies to use ti,impedance-control with a value. These
> properties got updated iduring review to specify whether
> min or max impedance. But the DT still uses the old values
> which never takes effect. Update the DT node by using the
> proper DT properties.
I'll apply this into omap-for-v4.13/dt as it's a fix
even though we're close to merge window opening.
Regards,
Tony
> [1] https://patchwork.kernel.org/patch/9239729/
>
> Fixes: 9868bc585ae2c ("ARM: dts: Add support for dra718-evm")
> Signed-off-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/boot/dts/dra71-evm.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
> index 4d57a55473af..a6298eb56978 100644
> --- a/arch/arm/boot/dts/dra71-evm.dts
> +++ b/arch/arm/boot/dts/dra71-evm.dts
> @@ -190,7 +190,7 @@
> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
> ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
> - ti,impedance-control = <0x1f>;
> + ti,min-output-impedance;
> };
>
> dp83867_1: ethernet-phy@3 {
> @@ -198,7 +198,7 @@
> ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_25_NS>;
> ti,tx-internal-delay = <DP83867_RGMIIDCTL_250_PS>;
> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_8_B_NIB>;
> - ti,impedance-control = <0x1f>;
> + ti,min-output-impedance;
> };
> };
>
> --
> 2.13.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-26 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 8:45 [PATCH] ARM: dts: dra71-evm: mdio: Fix impedance values Lokesh Vutla
[not found] ` <20170621084522.1828-1-lokeshvutla-l0cyMroinI0@public.gmane.org>
2017-06-26 9:37 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).