public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins
@ 2017-06-26 12:42 Jonathan Liu
  2017-06-26 12:45 ` Emmanuel Vadot
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Liu @ 2017-06-26 12:42 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	Russell King
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Jonathan Liu

The LCD0 controller on the A20 can do RGB output up to 8 bits per
channel. Add the pins for RGB888 output.

Signed-off-by: Jonathan Liu <net147-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 96bee776e145..09a0e89bed11 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1183,6 +1183,17 @@
 				function = "ir1";
 			};
 
+			lcd0_rgb888_pins: lcd0_rgb888@0 {
+				allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+						 "PD4", "PD5", "PD6", "PD7",
+						 "PD8", "PD9", "PD10", "PD11",
+						 "PD12", "PD13", "PD14", "PD15",
+						 "PD16", "PD17", "PD18", "PD19",
+						 "PD20", "PD21", "PD22", "PD23",
+						 "PD24", "PD25", "PD26", "PD27";
+				allwinner,function = "lcd0";
+			};
+
 			mmc0_pins_a: mmc0@0 {
 				pins = "PF0", "PF1", "PF2",
 				       "PF3", "PF4", "PF5";
-- 
2.13.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins
  2017-06-26 12:42 [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins Jonathan Liu
@ 2017-06-26 12:45 ` Emmanuel Vadot
       [not found]   ` <20170626144540.9af644d8ab6140f7f4718d06-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Emmanuel Vadot @ 2017-06-26 12:45 UTC (permalink / raw)
  To: Jonathan Liu
  Cc: Mark Rutland, devicetree, linux-sunxi, Russell King, linux-kernel,
	Chen-Yu Tsai, Rob Herring, Maxime Ripard, linux-arm-kernel

On Mon, 26 Jun 2017 22:42:49 +1000
Jonathan Liu <net147@gmail.com> wrote:

> The LCD0 controller on the A20 can do RGB output up to 8 bits per
> channel. Add the pins for RGB888 output.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 96bee776e145..09a0e89bed11 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -1183,6 +1183,17 @@
>  				function = "ir1";
>  			};
>  
> +			lcd0_rgb888_pins: lcd0_rgb888@0 {
> +				allwinner,pins = "PD0", "PD1", "PD2", "PD3",
> +						 "PD4", "PD5", "PD6", "PD7",
> +						 "PD8", "PD9", "PD10", "PD11",
> +						 "PD12", "PD13", "PD14", "PD15",
> +						 "PD16", "PD17", "PD18", "PD19",
> +						 "PD20", "PD21", "PD22", "PD23",
> +						 "PD24", "PD25", "PD26", "PD27";
> +				allwinner,function = "lcd0";
> +			};
> +

 We switch to standard pinctrl bindings so you need to use 'pins' and
'function' (i.e. without the 'allwinner,' prefix).

>  			mmc0_pins_a: mmc0@0 {
>  				pins = "PF0", "PF1", "PF2",
>  				       "PF3", "PF4", "PF5";
> -- 
> 2.13.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel


-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins
       [not found]   ` <20170626144540.9af644d8ab6140f7f4718d06-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
@ 2017-06-26 12:47     ` Jonathan Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Liu @ 2017-06-26 12:47 UTC (permalink / raw)
  To: Emmanuel Vadot
  Cc: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	Russell King, devicetree, linux-sunxi, linux-kernel,
	linux-arm-kernel

Hi Emmanuel,

On 26 June 2017 at 22:45, Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> wrote:
> On Mon, 26 Jun 2017 22:42:49 +1000
> Jonathan Liu <net147-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> The LCD0 controller on the A20 can do RGB output up to 8 bits per
>> channel. Add the pins for RGB888 output.
>>
>> Signed-off-by: Jonathan Liu <net147-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>  arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
>> index 96bee776e145..09a0e89bed11 100644
>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>> @@ -1183,6 +1183,17 @@
>>                               function = "ir1";
>>                       };
>>
>> +                     lcd0_rgb888_pins: lcd0_rgb888@0 {
>> +                             allwinner,pins = "PD0", "PD1", "PD2", "PD3",
>> +                                              "PD4", "PD5", "PD6", "PD7",
>> +                                              "PD8", "PD9", "PD10", "PD11",
>> +                                              "PD12", "PD13", "PD14", "PD15",
>> +                                              "PD16", "PD17", "PD18", "PD19",
>> +                                              "PD20", "PD21", "PD22", "PD23",
>> +                                              "PD24", "PD25", "PD26", "PD27";
>> +                             allwinner,function = "lcd0";
>> +                     };
>> +
>
>  We switch to standard pinctrl bindings so you need to use 'pins' and
> 'function' (i.e. without the 'allwinner,' prefix).
>

Thanks, I will change it for V2.

>>                       mmc0_pins_a: mmc0@0 {
>>                               pins = "PF0", "PF1", "PF2",
>>                                      "PF3", "PF4", "PF5";
>> --
>> 2.13.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
> --
> Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> <manu-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>

Regards,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-26 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-26 12:42 [PATCH] ARM: dts: sun7i: Add A20 LCD0 RGB888 pins Jonathan Liu
2017-06-26 12:45 ` Emmanuel Vadot
     [not found]   ` <20170626144540.9af644d8ab6140f7f4718d06-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
2017-06-26 12:47     ` Jonathan Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox