devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Christopher Bostic
	<cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
	linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config
Date: Wed, 28 Jun 2017 10:52:16 -0700	[thread overview]
Message-ID: <20170628175216.GA13730@roeck-us.net> (raw)
In-Reply-To: <a3f76a4e-6c44-9844-9840-f6b5b05255ed-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

On Wed, Jun 28, 2017 at 11:09:15AM -0500, Christopher Bostic wrote:
> 
> >>
> >>Why would there even be a need configure for no system reset?  The external
> >>mode 'wdt ext: External signal enable after timeout' can be sent off chip
> >>even if system reset is disabled.  The watchdog is doing something in this
> >>case and would require wdt instantiation.
> >>
> >Wouldn't that be "aspeed,external-signal" ?
> Yes that optional parameter would need to be specified in that situation, as
> well as 'aspeed,no-system-reset'.
> 

Ok, makes sense (after looking into the datasheet). The missing detail
is that there is a separate configuration bit for "Reset system after
timeout", which is set in addition to reset_{sys,soc,arm}.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-06-28 17:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 21:17 [PATCH v2 0/2] Add ASPEED watchdog device tree properties Christopher Bostic
     [not found] ` <20170627211734.60477-1-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-27 21:17   ` [PATCH v2 1/2] drivers/watchdog: Add optional ASPEED " Christopher Bostic
     [not found]     ` <20170627211734.60477-2-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-27 21:32       ` Guenter Roeck
     [not found]         ` <20170627213216.GA4132-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-27 21:42           ` Christopher Bostic
     [not found]             ` <6f2a77e0-e64c-70b7-812a-6a5e8a0b5e6f-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-27 22:07               ` Guenter Roeck
     [not found]                 ` <20170627220740.GA19461-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-28 14:55                   ` Christopher Bostic
     [not found]                     ` <ec4a255f-6052-0ad7-32e7-7a86b57e5283-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 15:06                       ` Guenter Roeck
2017-06-27 21:17   ` [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config Christopher Bostic
     [not found]     ` <20170627211734.60477-3-cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 11:31       ` Guenter Roeck
     [not found]         ` <606a2e11-2d43-5204-0bb6-9c4415ee03df-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-28 14:29           ` Christopher Bostic
     [not found]             ` <de0dc054-0813-fab1-d7ac-2f1d7ba61fd8-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 14:54               ` Guenter Roeck
     [not found]                 ` <20170628145452.GA30968-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-28 14:59                   ` Christopher Bostic
2017-06-28 15:08                     ` Guenter Roeck
     [not found]                       ` <20170628150846.GE30968-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-28 15:55                         ` Christopher Bostic
     [not found]                           ` <b6c53add-c165-3678-dfed-cb6f1798accc-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 16:06                             ` Guenter Roeck
     [not found]                               ` <20170628160649.GB8915-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2017-06-28 16:09                                 ` Christopher Bostic
     [not found]                                   ` <a3f76a4e-6c44-9844-9840-f6b5b05255ed-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-06-28 17:52                                     ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628175216.GA13730@roeck-us.net \
    --to=linux-0h96xk9xttrk1umjsbkqmq@public.gmane.org \
    --cc=cbostic-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).