* [PATCH v5 1/2] dt-bindings: input: Add Device tree bindings for Goodix GTx5 series touchscreen controller
@ 2017-06-29 2:13 Wang Yafei
2017-07-06 14:56 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Wang Yafei @ 2017-06-29 2:13 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Dmitry Torokhov
Cc: linux-input, devicetree, andrew, mouse
Signed-off-by: Wang Yafei <wangyafei@goodix.com>
---
since v1:
- Change device properties name
- Modified irq property format
- Modified linux,keycode format
- Modified panel configuration property name
- Remove time-delay properties
---
.../bindings/input/touchscreen/goodix-gtx5.txt | 61 ++++++++++++++++++++++
1 file changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
new file mode 100644
index 0000000..9bb82c5
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
@@ -0,0 +1,61 @@
+Device tree bindings for Goodix GTx5 series touchscreen controller
+
+Required properties:
+
+- compatible : Should be "goodix,gt7589"
+ or "goodix,gt8589"
+ or "goodix,gt9589"
+- reg : I2C address of the chip. Should be 0x5d or 0x14
+- interrupt-parent : Interrupt controller to which the chip is connected
+- interrupts : Interrupt to which the chip is connected
+- touchscreen-size-x : horizontal resolution of touchscreen(in pixels)
+- touchscreen-size-y : vertical resolution of touchscreen(in pixels)
+- touchscreen-max-id : panel supported max touch number.
+- touchscreen-max-w : panel max width value.
+
+Optional properties:
+- reset-gpios : reset gpio.
+- touchscreen-swapped-x-y : swap x/y axis coordinates.
+- linux,keycodes : Specifies an array of numeric keycode values to
+ be used for reporting button presses. The array can
+ contain up to 8 entries.
+- goodix,normal-cfg-X : touch device normal config data, this config data is
+ touchpanel manufacturer related. normal-cfg-X, X
+ represent for a panel manufacturer, X is less than 10.
+- vtouch-supply : power supply for the touch device.
+
+Example:
+i2c@00000000 {
+ /* ... */
+
+ gt8589@14 {
+ compatible = "goodix,gt8589";
+ reg = <0x14>;
+ interrupt-parent = <&msm_gpio>;
+ interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
+ vtouch-supply = <&pm8916_l15>;
+ reset-gpios = <&msm_gpio 12 0x0>;
+ touchscreen-max-id = <10>;
+ touchscreen-size-x = <400>;
+ touchscreen-size-y = <400>;
+ touchscreen-max-w = <400>;
+ linux,keycodes = <KEY_HOMEPAGE>, <KEY_MENU>, <KEY_BACK>;
+ goodix,normal-cfg-0 = [
+ 02 00 00 09 09 01 07 02 00 00 00 00 01 00 3C 00 07 07
+ 00 00 00 00 00 00 40 01 40 01 C8 00 96 00 F4 01 F4 01
+ F4 01 20 01 11 0A 0A 03 14 14 14 14 0A 0C 01 01 11 11
+ 11 00 14 14 14 14 14 14 14 14 14 00 00 0F 00 00 00 00
+ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+ 00 00 00 00 00 00 00 00 00 00 11 09 10 00 31 32 33 34
+ 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 CA 64 00
+ 00 00 00 00 00 00 09 00 13 00 00 00 00 00 00 00 00 00
+ 50 B0 19 00 19 00 05 00 00 00 00 0A 05 00 00 00 00 00
+ 01 00 FF 00 0B 06 0D 02 FF 04 05 03 07 01 08 0A 0E 11
+ 0F 10 09 13 0C 16 17 14 18 12 19 15 1D 1E 1C 1F 1B 20
+ 1A 2A 29 28 25 2B 27 21 FF 24 22 2C 26 23 FF 00 00 00
+ 00 00 00 00 00 00 00 00 00 00 00 00 80 80 80 80 80 80
+ 80 80 80 80 80 80 80 80 80 80 9F 22 01 AE];
+ };
+ };
+}
+
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 1/2] dt-bindings: input: Add Device tree bindings for Goodix GTx5 series touchscreen controller
2017-06-29 2:13 [PATCH v5 1/2] dt-bindings: input: Add Device tree bindings for Goodix GTx5 series touchscreen controller Wang Yafei
@ 2017-07-06 14:56 ` Rob Herring
2017-07-07 3:49 ` Wang Yafei
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2017-07-06 14:56 UTC (permalink / raw)
To: Wang Yafei
Cc: Mark Rutland, Dmitry Torokhov, linux-input, devicetree, andrew,
mouse
On Thu, Jun 29, 2017 at 10:13:27AM +0800, Wang Yafei wrote:
> Signed-off-by: Wang Yafei <wangyafei@goodix.com>
> ---
> since v1:
> - Change device properties name
> - Modified irq property format
> - Modified linux,keycode format
> - Modified panel configuration property name
> - Remove time-delay properties
> ---
> .../bindings/input/touchscreen/goodix-gtx5.txt | 61 ++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
> new file mode 100644
> index 0000000..9bb82c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
> @@ -0,0 +1,61 @@
> +Device tree bindings for Goodix GTx5 series touchscreen controller
> +
> +Required properties:
> +
> +- compatible : Should be "goodix,gt7589"
> + or "goodix,gt8589"
> + or "goodix,gt9589"
> +- reg : I2C address of the chip. Should be 0x5d or 0x14
> +- interrupt-parent : Interrupt controller to which the chip is connected
> +- interrupts : Interrupt to which the chip is connected
> +- touchscreen-size-x : horizontal resolution of touchscreen(in pixels)
> +- touchscreen-size-y : vertical resolution of touchscreen(in pixels)
> +- touchscreen-max-id : panel supported max touch number.
> +- touchscreen-max-w : panel max width value.
Just "see touchscreen.txt" is fine for the description of common
properties.
> +
> +Optional properties:
> +- reset-gpios : reset gpio.
> +- touchscreen-swapped-x-y : swap x/y axis coordinates.
> +- linux,keycodes : Specifies an array of numeric keycode values to
> + be used for reporting button presses. The array can
> + contain up to 8 entries.
> +- goodix,normal-cfg-X : touch device normal config data, this config data is
> + touchpanel manufacturer related. normal-cfg-X, X
> + represent for a panel manufacturer, X is less than 10.
> +- vtouch-supply : power supply for the touch device.
> +
> +Example:
> +i2c@00000000 {
> + /* ... */
> +
> + gt8589@14 {
> + compatible = "goodix,gt8589";
> + reg = <0x14>;
> + interrupt-parent = <&msm_gpio>;
> + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> + vtouch-supply = <&pm8916_l15>;
> + reset-gpios = <&msm_gpio 12 0x0>;
> + touchscreen-max-id = <10>;
> + touchscreen-size-x = <400>;
> + touchscreen-size-y = <400>;
> + touchscreen-max-w = <400>;
> + linux,keycodes = <KEY_HOMEPAGE>, <KEY_MENU>, <KEY_BACK>;
> + goodix,normal-cfg-0 = [
> + 02 00 00 09 09 01 07 02 00 00 00 00 01 00 3C 00 07 07
> + 00 00 00 00 00 00 40 01 40 01 C8 00 96 00 F4 01 F4 01
> + F4 01 20 01 11 0A 0A 03 14 14 14 14 0A 0C 01 01 11 11
> + 11 00 14 14 14 14 14 14 14 14 14 00 00 0F 00 00 00 00
> + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> + 00 00 00 00 00 00 00 00 00 00 11 09 10 00 31 32 33 34
> + 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 CA 64 00
> + 00 00 00 00 00 00 09 00 13 00 00 00 00 00 00 00 00 00
> + 50 B0 19 00 19 00 05 00 00 00 00 0A 05 00 00 00 00 00
> + 01 00 FF 00 0B 06 0D 02 FF 04 05 03 07 01 08 0A 0E 11
> + 0F 10 09 13 0C 16 17 14 18 12 19 15 1D 1E 1C 1F 1B 20
> + 1A 2A 29 28 25 2B 27 21 FF 24 22 2C 26 23 FF 00 00 00
> + 00 00 00 00 00 00 00 00 00 00 00 00 80 80 80 80 80 80
> + 80 80 80 80 80 80 80 80 80 80 9F 22 01 AE];
> + };
> + };
> +}
> +
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 1/2] dt-bindings: input: Add Device tree bindings for Goodix GTx5 series touchscreen controller
2017-07-06 14:56 ` Rob Herring
@ 2017-07-07 3:49 ` Wang Yafei
0 siblings, 0 replies; 3+ messages in thread
From: Wang Yafei @ 2017-07-07 3:49 UTC (permalink / raw)
To: Rob Herring
Cc: Mark Rutland, Dmitry Torokhov, linux-input-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, andrew-PiwChjOeyQzQT0dZR+AlfA,
mouse-PiwChjOeyQzQT0dZR+AlfA
On Thu, Jul 06, 2017 at 09:56:57AM -0500, Rob Herring wrote:
> On Thu, Jun 29, 2017 at 10:13:27AM +0800, Wang Yafei wrote:
> > Signed-off-by: Wang Yafei <wangyafei-PiwChjOeyQzQT0dZR+AlfA@public.gmane.org>
> > ---
> > since v1:
> > - Change device properties name
> > - Modified irq property format
> > - Modified linux,keycode format
> > - Modified panel configuration property name
> > - Remove time-delay properties
> > ---
> > .../bindings/input/touchscreen/goodix-gtx5.txt | 61 ++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
> > new file mode 100644
> > index 0000000..9bb82c5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix-gtx5.txt
> > @@ -0,0 +1,61 @@
> > +Device tree bindings for Goodix GTx5 series touchscreen controller
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "goodix,gt7589"
> > + or "goodix,gt8589"
> > + or "goodix,gt9589"
> > +- reg : I2C address of the chip. Should be 0x5d or 0x14
> > +- interrupt-parent : Interrupt controller to which the chip is connected
> > +- interrupts : Interrupt to which the chip is connected
> > +- touchscreen-size-x : horizontal resolution of touchscreen(in pixels)
> > +- touchscreen-size-y : vertical resolution of touchscreen(in pixels)
> > +- touchscreen-max-id : panel supported max touch number.
> > +- touchscreen-max-w : panel max width value.
>
> Just "see touchscreen.txt" is fine for the description of common
> properties.
Yes, the common properties are consistent with "touchscreen.txt"
> > +
> > +Optional properties:
> > +- reset-gpios : reset gpio.
> > +- touchscreen-swapped-x-y : swap x/y axis coordinates.
> > +- linux,keycodes : Specifies an array of numeric keycode values to
> > + be used for reporting button presses. The array can
> > + contain up to 8 entries.
> > +- goodix,normal-cfg-X : touch device normal config data, this config data is
> > + touchpanel manufacturer related. normal-cfg-X, X
> > + represent for a panel manufacturer, X is less than 10.
> > +- vtouch-supply : power supply for the touch device.
> > +
> > +Example:
> > +i2c@00000000 {
> > + /* ... */
> > +
> > + gt8589@14 {
> > + compatible = "goodix,gt8589";
> > + reg = <0x14>;
> > + interrupt-parent = <&msm_gpio>;
> > + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> > + vtouch-supply = <&pm8916_l15>;
> > + reset-gpios = <&msm_gpio 12 0x0>;
> > + touchscreen-max-id = <10>;
> > + touchscreen-size-x = <400>;
> > + touchscreen-size-y = <400>;
> > + touchscreen-max-w = <400>;
> > + linux,keycodes = <KEY_HOMEPAGE>, <KEY_MENU>, <KEY_BACK>;
> > + goodix,normal-cfg-0 = [
> > + 02 00 00 09 09 01 07 02 00 00 00 00 01 00 3C 00 07 07
> > + 00 00 00 00 00 00 40 01 40 01 C8 00 96 00 F4 01 F4 01
> > + F4 01 20 01 11 0A 0A 03 14 14 14 14 0A 0C 01 01 11 11
> > + 11 00 14 14 14 14 14 14 14 14 14 00 00 0F 00 00 00 00
> > + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > + 00 00 00 00 00 00 00 00 00 00 11 09 10 00 31 32 33 34
> > + 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 CA 64 00
> > + 00 00 00 00 00 00 09 00 13 00 00 00 00 00 00 00 00 00
> > + 50 B0 19 00 19 00 05 00 00 00 00 0A 05 00 00 00 00 00
> > + 01 00 FF 00 0B 06 0D 02 FF 04 05 03 07 01 08 0A 0E 11
> > + 0F 10 09 13 0C 16 17 14 18 12 19 15 1D 1E 1C 1F 1B 20
> > + 1A 2A 29 28 25 2B 27 21 FF 24 22 2C 26 23 FF 00 00 00
> > + 00 00 00 00 00 00 00 00 00 00 00 00 80 80 80 80 80 80
> > + 80 80 80 80 80 80 80 80 80 80 9F 22 01 AE];
> > + };
> > + };
> > +}
> > +
> > --
> > 2.7.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-07 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-29 2:13 [PATCH v5 1/2] dt-bindings: input: Add Device tree bindings for Goodix GTx5 series touchscreen controller Wang Yafei
2017-07-06 14:56 ` Rob Herring
2017-07-07 3:49 ` Wang Yafei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).