From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Ram Chandra Jangir <rjangir@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 3/3] pinctrl: qcom: add support to configure ipq40xx GPIO_PULL bits
Date: Wed, 5 Jul 2017 22:15:09 -0700 [thread overview]
Message-ID: <20170706051509.GO18666@tuxbook> (raw)
In-Reply-To: <e8b73406f36f47a408196f4bf8f6126ecc9e68aa.1498925339.git.chunkeey@googlemail.com>
On Sat 01 Jul 09:25 PDT 2017, Christian Lamparter wrote:
[..]
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h
> index 54fdd04ce9d5..71e97db5ba18 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.h
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.h
> @@ -115,6 +115,7 @@ struct msm_pinctrl_soc_data {
> const struct msm_pingroup *groups;
> unsigned ngroups;
> unsigned ngpios;
> + bool pull_no_keeper;
This should be accompanied by a kerneldoc update in the lines of:
@pull_no_keeper: The SoC does not support keeper bias
With something like that added:
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
prev parent reply other threads:[~2017-07-06 5:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-01 16:25 [PATCH v2 1/3] dt-bindings: pinctrl: add most other IPQ4019 pin functions and groups Christian Lamparter
2017-07-01 16:25 ` [PATCH v2 2/3] pinctrl: qcom: ipq4019: add remaining pin definitions Christian Lamparter
2017-07-01 16:25 ` [PATCH v2 3/3] pinctrl: qcom: add support to configure ipq40xx GPIO_PULL bits Christian Lamparter
2017-07-06 5:15 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706051509.GO18666@tuxbook \
--to=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjangir@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).