[PATCH v2 0/3] pwm: add pwm AO on meson gx

[PATCH v2 0/3] pwm: add pwm AO on meson gx

[Jerome Brunet]

The pwms found in the AO domain of the meson gx family have different
clock sources than the ones found in the EE domain. The AO pwms only
have 2 connected clock input which are clk81 and the crytal.

This patchset adds the necessary compatible and the clock data for it.

Changes since v1: [0]
* Correct clock source order for gxbb pwm ao. Documenation shows xtal as
  source #1 while it is actually source #0
* Add patch 3 to fix pwm calculation. Issue while testing pwm with clk81
  as clock source.

[0]:  https://lkml.kernel.org/r/20170607133013.4766-1-jbrunet@baylibre.com

Jerome Brunet (3):
  dt-bindings: pwm: meson: add comptabible for gxbb ao pwms
  pwm: meson: add compatible for the gxbb ao pwms
  pwm: meson: improve pwm calculation precision.

 .../devicetree/bindings/pwm/pwm-meson.txt          |  4 +-
 drivers/pwm/pwm-meson.c                            | 47 +++++++++++++++++-----
 2 files changed, 41 insertions(+), 10 deletions(-)

-- 
2.9.4

[PATCH v2 1/3] dt-bindings: pwm: meson: add comptabible for gxbb ao pwms

[Jerome Brunet]

Add compatible string to properly handle the PWMs found in the AO domain
of the gxbb (and gxl) family

Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 Documentation/devicetree/bindings/pwm/pwm-meson.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-meson.txt b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
index 5376a4468cb6..5b07bebbf6f7 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-meson.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
@@ -2,7 +2,9 @@ Amlogic Meson PWM Controller
 ============================
 
 Required properties:
-- compatible: Shall contain "amlogic,meson8b-pwm" or "amlogic,meson-gxbb-pwm".
+- compatible: Shall contain "amlogic,meson8b-pwm"
+                         or "amlogic,meson-gxbb-pwm"
+                         or "amlogic,meson-gxbb-ao-pwm"
 - #pwm-cells: Should be 3. See pwm.txt in this directory for a description of
   the cells format.
 
-- 
2.9.4

Re: [PATCH v2 1/3] dt-bindings: pwm: meson: add comptabible for gxbb ao pwms

[Rob Herring]

On Thu, Jun 08, 2017 at 02:24:14PM +0200, Jerome Brunet wrote:
> Add compatible string to properly handle the PWMs found in the AO domain
> of the gxbb (and gxl) family
> 
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-meson.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 0/3] pwm: add pwm AO on meson gx

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

On Thu, Jun 08, 2017 at 02:24:13PM +0200, Jerome Brunet wrote:
> The pwms found in the AO domain of the meson gx family have different
> clock sources than the ones found in the EE domain. The AO pwms only
> have 2 connected clock input which are clk81 and the crytal.
> 
> This patchset adds the necessary compatible and the clock data for it.
> 
> Changes since v1: [0]
> * Correct clock source order for gxbb pwm ao. Documenation shows xtal as
>   source #1 while it is actually source #0
> * Add patch 3 to fix pwm calculation. Issue while testing pwm with clk81
>   as clock source.
> 
> [0]:  https://lkml.kernel.org/r/20170607133013.4766-1-jbrunet@baylibre.com
> 
> Jerome Brunet (3):
>   dt-bindings: pwm: meson: add comptabible for gxbb ao pwms
>   pwm: meson: add compatible for the gxbb ao pwms
>   pwm: meson: improve pwm calculation precision.
> 
>  .../devicetree/bindings/pwm/pwm-meson.txt          |  4 +-
>  drivers/pwm/pwm-meson.c                            | 47 +++++++++++++++++-----
>  2 files changed, 41 insertions(+), 10 deletions(-)

For some reason the Author field keeps getting set to:

	jbrunet <jbrunet@baylibre.com>

It seems like the headers are correct, so maybe this is patchwork
messing things up?

Anyway, I've applied the series and manually fixed up the Author field.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/3] pwm: add pwm AO on meson gx

[Jerome Brunet]

On Thu, 2017-07-06 at 08:59 +0200, Thierry Reding wrote:
> On Thu, Jun 08, 2017 at 02:24:13PM +0200, Jerome Brunet wrote:
> > The pwms found in the AO domain of the meson gx family have different
> > clock sources than the ones found in the EE domain. The AO pwms only
> > have 2 connected clock input which are clk81 and the crytal.
> > 
> > This patchset adds the necessary compatible and the clock data for it.
> > 
> > Changes since v1: [0]
> > * Correct clock source order for gxbb pwm ao. Documenation shows xtal as
> >   source #1 while it is actually source #0
> > * Add patch 3 to fix pwm calculation. Issue while testing pwm with clk81
> >   as clock source.
> > 
> > [0]:  https://lkml.kernel.org/r/20170607133013.4766-1-jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
> > 
> > Jerome Brunet (3):
> >   dt-bindings: pwm: meson: add comptabible for gxbb ao pwms
> >   pwm: meson: add compatible for the gxbb ao pwms
> >   pwm: meson: improve pwm calculation precision.
> > 
> >  .../devicetree/bindings/pwm/pwm-meson.txt          |  4 +-
> >  drivers/pwm/pwm-meson.c                            | 47 +++++++++++++++++
> > -----
> >  2 files changed, 41 insertions(+), 10 deletions(-)
> 
> For some reason the Author field keeps getting set to:
> 
> 	jbrunet <jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> 
> It seems like the headers are correct, so maybe this is patchwork
> messing things up?

And it strikes again ... :(
I already had the issue with https://patchwork.kernel.org a few month ago.
I have contacted the kernel.org helpdesk about it and here is the explanation:

"Patchwork treats users and patch submitters slightly differently, so once your
entry is created upon first patch submission, it sticks forever. I've adjusted
your entry manually per your request."

So my very first patch on the ML must have been malformed somehow.

> 
> Anyway, I've applied the series and manually fixed up the Author field.

Thanks a lot for this ! 
Any idea who I may contact to get this "manual adjustment" done on https://patch
work.ozlabs.org/ ?


> 
> Thanks,
> Thierry

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] pwm: add pwm AO on meson gx

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2413 bytes --]

On Thu, Jul 06, 2017 at 11:02:20AM +0200, Jerome Brunet wrote:
> On Thu, 2017-07-06 at 08:59 +0200, Thierry Reding wrote:
> > On Thu, Jun 08, 2017 at 02:24:13PM +0200, Jerome Brunet wrote:
> > > The pwms found in the AO domain of the meson gx family have different
> > > clock sources than the ones found in the EE domain. The AO pwms only
> > > have 2 connected clock input which are clk81 and the crytal.
> > > 
> > > This patchset adds the necessary compatible and the clock data for it.
> > > 
> > > Changes since v1: [0]
> > > * Correct clock source order for gxbb pwm ao. Documenation shows xtal as
> > >   source #1 while it is actually source #0
> > > * Add patch 3 to fix pwm calculation. Issue while testing pwm with clk81
> > >   as clock source.
> > > 
> > > [0]:  https://lkml.kernel.org/r/20170607133013.4766-1-jbrunet@baylibre.com
> > > 
> > > Jerome Brunet (3):
> > >   dt-bindings: pwm: meson: add comptabible for gxbb ao pwms
> > >   pwm: meson: add compatible for the gxbb ao pwms
> > >   pwm: meson: improve pwm calculation precision.
> > > 
> > >  .../devicetree/bindings/pwm/pwm-meson.txt          |  4 +-
> > >  drivers/pwm/pwm-meson.c                            | 47 +++++++++++++++++
> > > -----
> > >  2 files changed, 41 insertions(+), 10 deletions(-)
> > 
> > For some reason the Author field keeps getting set to:
> > 
> > 	jbrunet <jbrunet@baylibre.com>
> > 
> > It seems like the headers are correct, so maybe this is patchwork
> > messing things up?
> 
> And it strikes again ... :(
> I already had the issue with https://patchwork.kernel.org a few month ago.
> I have contacted the kernel.org helpdesk about it and here is the explanation:
> 
> "Patchwork treats users and patch submitters slightly differently, so once your
> entry is created upon first patch submission, it sticks forever. I've adjusted
> your entry manually per your request."
> 
> So my very first patch on the ML must have been malformed somehow.
> 
> > 
> > Anyway, I've applied the series and manually fixed up the Author field.
> 
> Thanks a lot for this ! 
> Any idea who I may contact to get this "manual adjustment" done on https://patch
> work.ozlabs.org/ ?

I /think/ Jeremy Kerr (To'ed) would be a good person to contact about
this.

Jeremy, anything you can do about this?

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/3] pwm: add pwm AO on meson gx

[Jeremy Kerr]

Hi Thierry,

> I /think/ Jeremy Kerr (To'ed) would be a good person to contact about
> this.
> 
> Jeremy, anything you can do about this?

OK, all sorted. I've updated Jerome's entry in the database to suit.

Cheers,


Jeremy

Re: [PATCH v2 0/3] pwm: add pwm AO on meson gx

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

On Fri, Jul 14, 2017 at 01:51:12PM +0800, Jeremy Kerr wrote:
> Hi Thierry,
> 
> > I /think/ Jeremy Kerr (To'ed) would be a good person to contact about
> > this.
> > 
> > Jeremy, anything you can do about this?
> 
> OK, all sorted. I've updated Jerome's entry in the database to suit.

Headers do indeed look correct now.

Thanks a lot, Jeremy.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]