From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size
Date: Thu, 6 Jul 2017 20:52:05 +0200 [thread overview]
Message-ID: <20170706185205.f4jwskpnz4d3udvv@flea> (raw)
In-Reply-To: <20170706085334.25380-1-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> The datasheet said that emac register size is 0x1000 not 0x104
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 716e7d668dec..5a57b67c9b77 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -406,7 +406,7 @@
> emac: ethernet@1c30000 {
> compatible = "allwinner,sun8i-h3-emac";
> syscon = <&syscon>;
> - reg = <0x01c30000 0x104>;
> + reg = <0x01c30000 0x1000>;
The size is actually 0x10000. I fixed it and applied.
The A64 DTSI has the same issue, can you send a patch for this one
too?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-07-06 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 8:53 [PATCH] ARM: sunxi: h3/h5: Correct emac register size Corentin Labbe
2017-07-06 18:52 ` Maxime Ripard [this message]
2017-07-06 19:05 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706185205.f4jwskpnz4d3udvv@flea \
--to=maxime.ripard@free-electrons.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).