[PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Vladimir Barinov]

From: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>

This enables I2C4 for ULCB board

Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 6e5ffc8..e402f16f 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -189,6 +189,12 @@
 	};
 };
 
+&i2c4 {
+	status = "okay";
+
+	clock-frequency = <400000>;
+};
+
 &i2c_dvfs {
 	status = "okay";
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Geert Uytterhoeven]

On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>
> This enables I2C4 for ULCB board
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -189,6 +189,12 @@
>         };
>  };
>
> +&i2c4 {
> +       status = "okay";
> +
> +       clock-frequency = <400000>;

Is this a bus limitation, or a limitation for the VC6 that's added in a later
patch?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Simon Horman]

On Mon, Jul 10, 2017 at 10:20:02AM +0200, Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> >
> > This enables I2C4 for ULCB board
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

FWIIW, I only got this one patch of this series.

> 
> > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > @@ -189,6 +189,12 @@
> >         };
> >  };
> >
> > +&i2c4 {
> > +       status = "okay";
> > +
> > +       clock-frequency = <400000>;
> 
> Is this a bus limitation, or a limitation for the VC6 that's added in a later
> patch?
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

Re: [PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Geert Uytterhoeven]

Hi Simon

On Mon, Jul 10, 2017 at 10:33 AM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote:
> FWIIW, I only got this one patch of this series.

I believe the others have an "x/5" prefix. instead of "x/6".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Simon Horman]

On Mon, Jul 10, 2017 at 10:39:14AM +0200, Geert Uytterhoeven wrote:
> Hi Simon
> 
> On Mon, Jul 10, 2017 at 10:33 AM, Simon Horman <horms@verge.net.au> wrote:
> > FWIIW, I only got this one patch of this series.
> 
> I believe the others have an "x/5" prefix. instead of "x/6".

Thanks, I see them.

Re: [PATCH 1/6] arm64: dts: renesas: ulcb: Enable I2C4

[Vladimir Barinov]

Hi Geert,

Thank you for review!

On 10.07.2017 11:20, Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
>>
>> This enables I2C4 for ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> @@ -189,6 +189,12 @@
>>          };
>>   };
>>
>> +&i2c4 {
>> +       status = "okay";
>> +
>> +       clock-frequency = <400000>;
> Is this a bus limitation, or a limitation for the VC6 that's added in a later
> patch?
Yes, IDT VC5 clock generator supports up to 400kHz.

I've explicitly set 400kHz as default since the documentation says that 
the default value is 100kHz if 'clock-frequency' not set:
Documentation/devicetree/bindings/i2c/i2c-rcar.txt

Regards,
Vladimir