From: Tony Lindgren <tony@atomide.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: codec: cpcap: new codec
Date: Mon, 10 Jul 2017 22:15:41 -0700 [thread overview]
Message-ID: <20170711051540.GV3730@atomide.com> (raw)
In-Reply-To: <20170710175152.2jglyjezvptamreq@sirena.org.uk>
* Mark Brown <broonie@kernel.org> [170710 10:52]:
> On Fri, Jul 07, 2017 at 06:42:27PM +0200, Sebastian Reichel wrote:
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id cpcap_audio_of_match[] = {
> > + { .compatible = "motorola,cpcap-audio-codec", },
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(of, cpcap_audio_of_match);
> > +#endif
>
> If this is part of a MFD shouldn't the parent device register it without
> it needing to be in the DT?
Having the MFD core part just do devm_of_platform_populate() leaves out
dependencies between the MFD core and it's child devices.
There are also a lot of board specific configuration to be done for many
child devices such as ADC wiring, GPIO pins used, and macro firmware
usage.
Not sure what all board specific stuff needs to be configured for this
driver yet, but it seems at least the macro interrupt wiring needs to
be configured. I would not be surprised to find GPIOs or ADC being used
for some connector detection too.
Regards,
Tony
next prev parent reply other threads:[~2017-07-11 5:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:42 [PATCH 0/3] Motorola Droid 4 Audio Support Sebastian Reichel
2017-07-07 16:42 ` [PATCH 1/3] ASoC: codec: cpcap: new codec Sebastian Reichel
[not found] ` <20170707164229.5868-2-sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-07-09 5:39 ` Tony Lindgren
2017-07-10 15:28 ` Rob Herring
2017-07-10 17:51 ` Mark Brown
2017-07-11 5:15 ` Tony Lindgren [this message]
2017-07-11 10:49 ` Mark Brown
2017-07-11 12:13 ` Sebastian Reichel
2017-07-11 13:33 ` Mark Brown
2017-07-07 16:42 ` [PATCH 2/3] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2017-07-07 16:42 ` [PATCH 3/3] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
2017-07-10 12:26 ` Mark Brown
2017-07-24 19:19 ` Pavel Machek
2017-07-25 9:08 ` Sebastian Reichel
2017-07-08 5:27 ` [PATCH 0/3] Motorola Droid 4 Audio Support Tony Lindgren
[not found] ` <20170708052753.GM3730-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-07-08 11:34 ` Sebastian Reichel
2017-07-09 5:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711051540.GV3730@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).