From: Stephen Boyd <sboyd@codeaurora.org>
To: Suman Anna <s-anna@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Tero Kristo <t-kristo@ti.com>, Nishanth Menon <nm@ti.com>,
Dave Gerlach <d-gerlach@ti.com>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers
Date: Tue, 11 Jul 2017 18:09:23 -0700 [thread overview]
Message-ID: <20170712010923.GP22780@codeaurora.org> (raw)
In-Reply-To: <20170711223615.29398-1-s-anna@ti.com>
On 07/11, Suman Anna wrote:
> The clock consumer usage description was erroneously referring to
> couple of dt-binding headers that are no longer valid. The definition
> and/or usage of these headers is incorrect and the only file present
> at the moment, dt-bindings/soc/k2g.h is also being cleaned up. The
> examples in this binding were updated properly, but the update to
> description was missed out. So, fix this.
>
> Fixes: 8f306cfe4383 ("Documentation: dt: Add TI SCI clock driver")
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Stephen,
>
> Looks like this was missed during the update/repost of the ti-sci-clk
> driver/binding. FYI, Santosh is going to pickup the header file cleanup
> patch https://patchwork.kernel.org/patch/9741279/ for the next merge
> window.
I'll let Rob apply this as it is purely a binding document update.
>
> regards
> Suman
>
> Documentation/devicetree/bindings/clock/ti,sci-clk.txt | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> index 1e884c40ab50..4e59dc6b1778 100644
> --- a/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.txt
> @@ -14,10 +14,9 @@ Required properties:
> - compatible: Must be "ti,k2g-sci-clk"
> - #clock-cells: Shall be 2.
> In clock consumers, this cell represents the device ID and clock ID
> - exposed by the PM firmware. The assignments can be found in the header
> - files <dt-bindings/genpd/<soc>.h> (which covers the device IDs) and
> - <dt-bindings/clock/<soc>.h> (which covers the clock IDs), where <soc>
> - is the SoC involved, for example 'k2g'.
> + exposed by the PM firmware. The list of valid values for the device IDs
> + and clocks IDs for 66AK2G SoC are documented at
> + http://processors.wiki.ti.com/index.php/TISCI#66AK2G02_Data
>
I hope the weblink doesn't die in the future. Why can't we copy
it into the binding document here for safe keeping?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-12 1:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 22:36 [PATCH] dt-bindings: clock: ti-sci: Fix incorrect usage of headers Suman Anna
2017-07-12 1:09 ` Stephen Boyd [this message]
2017-07-12 15:21 ` Suman Anna
2017-07-17 17:04 ` Rob Herring
2017-07-17 17:14 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712010923.GP22780@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).