From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] ARM: dts: imx6q-bx50v3: Enable i2c recovery mechanism Date: Wed, 12 Jul 2017 15:14:48 +0800 Message-ID: <20170712071446.GH3172@dragon> References: <20170628123531.26996-1-romain.perier@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170628123531.26996-1-romain.perier-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Romain Perier Cc: Sascha Hauer , Fabio Estevam , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Jose Alarcon , Nandor Han List-Id: devicetree@vger.kernel.org On Wed, Jun 28, 2017 at 02:35:31PM +0200, Romain Perier wrote: > From: Jose Alarcon > > This commit enables i2c recovery, supported by the i2c core subsystem. > It defines the required GPIOs for SDA and SLC lines. > > Signed-off-by: Jose Alarcon > Signed-off-by: Nandor Han > Signed-off-by: Romain Perier > --- > arch/arm/boot/dts/imx6q-bx50v3.dtsi | 42 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-bx50v3.dtsi b/arch/arm/boot/dts/imx6q-bx50v3.dtsi > index c90b26f..75201ca 100644 > --- a/arch/arm/boot/dts/imx6q-bx50v3.dtsi > +++ b/arch/arm/boot/dts/imx6q-bx50v3.dtsi > @@ -94,6 +94,29 @@ > }; > }; > > +&iomuxc { > + pinctrl_i2c1_gpio: i2c1gpiogrp { > + fsl,pins = < > + MX6QDL_PAD_CSI0_DAT8__GPIO5_IO26 0x1b0b0 > + MX6QDL_PAD_CSI0_DAT9__GPIO5_IO27 0x1b0b0 > + >; > + }; > + > + pinctrl_i2c2_gpio: i2c2gpiogrp { > + fsl,pins = < > + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x1b0b0 > + MX6QDL_PAD_KEY_ROW3__GPIO4_IO13 0x1b0b0 > + >; > + }; > + > + pinctrl_i2c3_gpio: i2c3gpiogrp { > + fsl,pins = < > + MX6QDL_PAD_GPIO_3__GPIO1_IO03 0x1b0b0 > + MX6QDL_PAD_GPIO_6__GPIO1_IO06 0x1b0b0 > + >; > + }; > +}; > + We generally suggest to put iomuxc node at the bottom of the file, as it usually contains a lot of pinctrl data which might hurt the readability of the file. You iomuxc doesn't have that much data, so it could be added in alphabetic order. > &ecspi5 { > cs-gpios = <&gpio1 17 GPIO_ACTIVE_HIGH>; > pinctrl-names = "default"; > @@ -111,6 +134,11 @@ > }; > > &i2c1 { > + pinctrl-names = "default", "gpio"; > + pinctrl-1 = <&pinctrl_i2c1_gpio>; > + sda-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>; > + scl-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>; > + > pca9547: mux@70 { > compatible = "nxp,pca9547"; > reg = <0x70>; > @@ -261,6 +289,20 @@ > }; > }; > > +&i2c2 { > + pinctrl-names = "default", "gpio"; > + pinctrl-1 = <&pinctrl_i2c2_gpio>; > + sda-gpios = <&gpio4 13 GPIO_ACTIVE_HIGH>; > + scl-gpios = <&gpio4 12 GPIO_ACTIVE_HIGH>; > +}; > + > +&i2c3 { > + pinctrl-names = "default", "gpio"; > + pinctrl-1 = <&pinctrl_i2c3_gpio>; > + sda-gpios = <&gpio1 06 GPIO_ACTIVE_HIGH>; s/06/6 > + scl-gpios = <&gpio1 03 GPIO_ACTIVE_HIGH>; s/03/3 Shawn > +}; > + > &usdhc4 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc4>; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html