From: Andrew Lunn <andrew@lunn.ch>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Moritz Fischer <mdf@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
mark.rutland@arm.com, robh+dt@kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev
Date: Fri, 14 Jul 2017 03:34:35 +0200 [thread overview]
Message-ID: <20170714013435.GA9065@lunn.ch> (raw)
In-Reply-To: <20170714003111.GA13512@tyrael.ni.corp.natinst.com>
> > > + /* not sure if this is the correct way of dealing with this ... */
> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg);
> > > + ndev->phydev->advertising = ndev->phydev->supported;
> > > + ndev->phydev->autoneg = AUTONEG_DISABLE;
> >
> > What are you trying to achieve?
>
> Basically can't do Autoneg, I'll need to take a closer look.
Hi Moritz
What i actually think you mean, is it can only do 1Gbps. So you could
autoneg, but only advertise 1Gbps. Look at masking out
PHY_10BT_FEATURES and PHY_100BT_FEATURES.
Take a look at:
http://elixir.free-electrons.com/linux/latest/source/drivers/net/ethernet/renesas/ravb_main.c#L1045
It might actually make sense to add a phy_set_min_speed(), a mirror to
phy_set_max_speed().
Andrew
next prev parent reply other threads:[~2017-07-14 1:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:21 [PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev Moritz Fischer
2017-07-13 21:21 ` [PATCH 2/2] net: ethernet: nixge: Add support " Moritz Fischer
[not found] ` <1499980909-11702-2-git-send-email-mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-13 22:36 ` Andrew Lunn
[not found] ` <20170713223636.GF3120-g2DYL2Zd6BY@public.gmane.org>
2017-07-14 0:31 ` Moritz Fischer
2017-07-14 1:34 ` Andrew Lunn [this message]
[not found] ` <20170714013435.GA9065-g2DYL2Zd6BY@public.gmane.org>
2017-07-14 3:36 ` Moritz Fischer
2017-07-15 14:36 ` kbuild test robot
2017-07-14 5:54 ` kbuild test robot
2017-07-14 0:33 ` [PATCH 1/2] dt-bindings: net: Add bindings " YUAN Linyu
2017-07-14 0:36 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714013435.GA9065@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).