devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wolf Entwicklungen <Marcus.Wolf@Wolf-Entwicklungen.de>
Cc: robh+dt@kernel.org, linux-kernel@vger.kernel.org,
	devel@driverdev.osuosl.org, grant.likely@linaro.org,
	devicetree@vger.kernel.org
Subject: Re: Submit of a driver for Pi433 - a radio module for Raspberry Pi
Date: Sun, 16 Jul 2017 08:45:46 +0200	[thread overview]
Message-ID: <20170716064546.GA11484@kroah.com> (raw)
In-Reply-To: <8d152de9387d8ebae5b3cd11277e8ada-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheXH4CVVE=-webmailer1@server05.webmailer.hosteurope.de>

On Sat, Jul 15, 2017 at 07:05:04PM +0200, Wolf Entwicklungen wrote:
> Am Sa, 15.07.2017, 15:47 schrieb Greg KH:
> > On Sat, Jul 15, 2017 at 03:40:30PM +0200, Marcus Wolf wrote:
> >> Hi Greg,
> >>
> 
> Hi Greg,
> 
> now I added a TODO file and did a manual patchwork with lines of the old patch
> (git format-patch master --stdout -p > pi433_patch) and the newer patch (git
> diff master > pi433_patch). Stil don't know how to retreive multiple commits
> in one single patch directly from git :-/
> I did my best to meet a lot of rules of the link, you send me.If
> there is stil something essential wrong or missing, please excuse and let me know.
> 
> Especially I was in doubt about the verbosity of the change log. If you'd like
> to see the list of features of the driver over there (please see my first mail),
> let me know and I'll add.


Can you resend it without all of this stuff here, a patch email should just
contain the patch itself, look at all of the examples on the mailing
lists for how they look.

> From: Marcus Wolf <linux@Wolf-Entwicklungen.de>
> Date: Tue,15 Jul 2017 17:52:06 +0100
> Subject: [PATCH 1/1] drivers/staging/pi433: New driver
> 
> Added a driver for the pi433 radio module
> (see https://www.pi433.de/en.html for details).
> Signed-off-by: Marcus Wolf <linux@Wolf-Entwicklungen.de>

Need a blank line before signed-off-by.

> Tested-by: Marcus Wolf <linux@Wolf-Entwicklungen.de> on Raspbian, running Kernel v4.12

No need for a tested-by from something that wrote, that is implied :)

Almost there...

thanks,

greg k-h

  reply	other threads:[~2017-07-16  6:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 16:02 Submit of a driver for Pi433 - a radio module for Raspberry Pi Marcus Wolf
2017-07-12  7:43 ` Greg KH
2017-07-15 11:15   ` Marcus Wolf
     [not found]     ` <197075499.65628.1500117344413-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 11:24       ` Greg KH
2017-07-15 12:26         ` Marcus Wolf
     [not found]         ` <20170715112454.GB1753-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 12:59           ` Marcus Wolf
     [not found]             ` <89433969.66090.1500123565835-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:02               ` Greg KH
     [not found]                 ` <20170715130220.GA22977-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 13:10                   ` Marcus Wolf
     [not found]                     ` <826180465.66159.1500124248340-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:16                       ` Greg KH
2017-07-15 13:40                         ` Marcus Wolf
     [not found]                           ` <1152815224.66246.1500126030682-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-15 13:47                             ` Greg KH
     [not found]                               ` <20170715134739.GA20360-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-15 17:05                                 ` Wolf Entwicklungen
2017-07-16  6:45                                   ` Greg KH [this message]
     [not found]                                     ` <20170716064546.GA11484-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-16  9:52                                       ` [PATCH 1/1] drivers/staging/pi433: New driver Wolf Entwicklungen
     [not found]                                         ` <39f4e59cae6d241235f8f2cc6eebb33c-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheVn4GUFc=-webmailer1-aF9hzfVklKyMhzHtofonGKYwuClDyyMfX55GXzBGTY8@public.gmane.org>
2017-07-16 10:15                                           ` Greg KH
     [not found]                                             ` <20170716101531.GA19773-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-16 13:53                                               ` Marcus Wolf
2017-07-16 14:47                                                 ` Greg KH
2017-07-17 13:26                                           ` kbuild test robot
     [not found]                                             ` <201707172156.DCyTyWc2%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-07-20 11:23                                               ` Marcus Wolf
2017-07-20 11:31                                                 ` Greg KH
2017-07-20 11:37                                                 ` Dan Carpenter
2017-07-20 12:27                                                   ` Geert Uytterhoeven
2017-07-20 15:56                                                     ` [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation Marcus Wolf
     [not found]                                                       ` <255867683.7064.1500566196444-mPx3TeDXVI9fnkZfMEZNjw@public.gmane.org>
2017-07-29  0:01                                                         ` Greg KH
     [not found]                                                           ` <20170729000118.GA28861-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-29  8:51                                                             ` Marcus Wolf
2017-07-29 22:21                                                               ` Greg KH
     [not found]                                                                 ` <20170729222127.GB16460-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-07-30 15:21                                                                   ` Marcus Wolf
     [not found]                                                     ` <CAMuHMdVgw=V6f8wzcXvS3gk8GK0bOpdgs_jxL6Y_X9idJD_x3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-20 15:57                                                       ` Test of " Marcus Wolf
2017-07-17  6:18                                         ` [PATCH 1/1] drivers/staging/pi433: New driver kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170716064546.GA11484@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Marcus.Wolf@Wolf-Entwicklungen.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).