Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability

From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] dt-bindings: display: sunxi: Improve endpoint ID scheme readability
Date: Mon, 17 Jul 2017 08:21:02 +0200	[thread overview]
Message-ID: <20170717062102.za55es6ejikkkcqv@flea> (raw)
In-Reply-To: <CAGb2v64aoXsoE=YL_PFLkdU7rBZdpqhg37CKuQU-1F+SV9=zcw@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1858 bytes --]

Hi,

On Wed, Jul 12, 2017 at 10:38:38AM +0800, Chen-Yu Tsai wrote:
> On Wed, Jul 12, 2017 at 3:31 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Mon, Jul 10, 2017 at 11:48:00PM +0800, Chen-Yu Tsai wrote:
> >> On Sun, Jun 18, 2017 at 10:05 PM, Rob Herring <robh@kernel.org> wrote:
> >> > On Wed, Jun 14, 2017 at 02:30:16PM +0800, Chen-Yu Tsai wrote:
> >> >> The explanation for the endpoint ID numbering scheme is convoluted
> >> >> and hard to understand.
> >> >>
> >> >> This patch aims to improve the readability of it by combining the
> >> >> existing two paragraphs, while also providing a diagram example,
> >> >> and how endpoints should be numbered based on that example.
> >> >>
> >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> >> ---
> >> >>
> >> >> Hope this helps. I'm not sure I can improve this even more without
> >> >> spelling out all cases.
> >> >>
> >> >> ---
> >> >>  .../bindings/display/sunxi/sun4i-drm.txt           | 36 ++++++++++++++++------
> >> >>  1 file changed, 27 insertions(+), 9 deletions(-)
> >> >
> >> > Acked-by: Rob Herring <robh@kernel.org>
> >>
> >> Maxime, this patch seems to have fallen through the cracks.
> >>
> >> Could you queue it as a fix for 4.13?
> >
> > Sorry, I don't know why I overlooked it.
> >
> > Is it really 4.13 material though? It doesn't look that urgent.
> 
> Unless I'm mistaken, this clarifies the numbering scheme introduced
> in 4.13. I'd say that's enough reason to have it in the same release.
> 
> But I should update the diagram first. The backend <-> TCON mux is
> missing. And maybe a Fixes tag.

If it's just clarification, I don't think we should push it as a fix,
but and it can definitely wait.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel