From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Shawn Guo <shawnguo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Bai Ping <ping.bai@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Octavian Purdila <octavian.purdila@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx
Date: Mon, 17 Jul 2017 16:00:22 +0200 [thread overview]
Message-ID: <20170717160022.6892b839@karo-electronics.de> (raw)
In-Reply-To: <cover.1500041281.git.leonard.crestez@nxp.com>
Hi,
On Fri, 14 Jul 2017 17:11:05 +0300 Leonard Crestez wrote:
> On imx6sx accessing OCOTP directly is wrong because the ocotp clock needs to be
> enabled first. Fix this by adding a nvmem-cells binding and using it on imx6sx,
> imx6ul and imx6ull.
>
> The existing binding is kept around because it works fine on imx6qdl.
>
> This was initially reported by Lothar Waßmann <LW@KARO-electronics.de> in reply
> to a patch adding imx6ul/ull support:
>
> Link: https://lkml.org/lkml/2017/6/9/578
>
> ---
> Changes since v1:
> * Move nvmem_cell_read_u32 to nvmem core (Shawn Guo, Srinivas Kandagatla)
> * Adjust binding description (Rob Herring)
> * Adjust formatting of thermal info cells (Shawn Guo)
> * Link: https://lkml.org/lkml/2017/7/6/426
>
> Leonard Crestez (5):
> thermal: imx: Add nvmem-cells alternate binding for OCOTP access
> nvmem: core: Add nvmem_cell_read_u32
> thermal: imx: Add support for reading OCOTP through nvmem
> ARM: dts: imx6sx: Use nvmem-cells for tempmon
> ARM: dts: imx6ul: Add imx6ul-tempmon
>
> .../devicetree/bindings/thermal/imx-thermal.txt | 7 ++
> arch/arm/boot/dts/imx6sx.dtsi | 13 ++-
> arch/arm/boot/dts/imx6ul.dtsi | 19 ++++
> drivers/nvmem/core.c | 37 ++++++++
> drivers/thermal/imx_thermal.c | 103 +++++++++++++++------
> include/linux/nvmem-consumer.h | 8 ++
> 6 files changed, 156 insertions(+), 31 deletions(-)
>
Works as expected on TX6UL-5010.
Tested-By: Lothar Waßmann <LW@KARO-electronics.de>
Lothar Waßmann
next prev parent reply other threads:[~2017-07-17 14:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 14:11 [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx Leonard Crestez
[not found] ` <cover.1500041281.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-07-14 14:11 ` [PATCH v2 1/5] thermal: imx: Add nvmem-cells alternate binding for OCOTP access Leonard Crestez
2017-07-17 18:57 ` Rob Herring
2017-07-14 14:11 ` [PATCH v2 5/5] ARM: dts: imx6ul: Add imx6ul-tempmon Leonard Crestez
2017-07-14 14:11 ` [PATCH v2 2/5] nvmem: core: Add nvmem_cell_read_u32 Leonard Crestez
2017-07-25 8:07 ` Shawn Guo
[not found] ` <eedf98ecb5d9d47f3c8b9ffbf58e03c7a2fb8db4.1500041281.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-08-25 9:07 ` Srinivas Kandagatla
2017-08-28 10:51 ` Leonard Crestez
2017-07-14 14:11 ` [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem Leonard Crestez
2017-07-25 8:08 ` Shawn Guo
2017-08-08 7:21 ` Zhang Rui
[not found] ` <1502176915.4296.1.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-08 11:00 ` Srinivas Kandagatla
2017-08-08 11:38 ` Leonard Crestez
2017-08-08 11:44 ` Srinivas Kandagatla
2017-08-08 12:58 ` Zhang Rui
[not found] ` <1502197100.4296.45.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-08-16 15:33 ` Leonard Crestez
[not found] ` <1502897621.23210.41.camel-3arQi8VN3Tc@public.gmane.org>
2017-08-25 2:20 ` Zhang Rui
2017-07-14 14:11 ` [PATCH v2 4/5] ARM: dts: imx6sx: Use nvmem-cells for tempmon Leonard Crestez
2017-07-25 8:11 ` Shawn Guo
[not found] ` <3cda26e557510055f05cea92b81678743e0ea9e3.1500041281.git.leonard.crestez-3arQi8VN3Tc@public.gmane.org>
2017-10-18 2:29 ` Shawn Guo
2017-07-17 14:00 ` Lothar Waßmann [this message]
2017-08-31 8:48 ` [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx Shawn Guo
2017-08-31 13:11 ` Zhang Rui
[not found] ` <1504185083.2749.2.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-09-20 1:40 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170717160022.6892b839@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=octavian.purdila@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).