From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled Date: Tue, 18 Jul 2017 15:52:03 -0700 Message-ID: <20170718225203.GD18179@codeaurora.org> References: <1500364414-10021-1-git-send-email-gabriel.fernandez@st.com> <1500364414-10021-3-git-send-email-gabriel.fernandez@st.com> <55bc0f3f-67ed-a15f-5b71-d87044fd5237@mleia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55bc0f3f-67ed-a15f-5b71-d87044fd5237-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vladimir Zapolskiy Cc: gabriel.fernandez-qxv4g6HH51o@public.gmane.org, Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Nicolas Pitre , Arnd Bergmann , daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, andrea.merello-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, radoslaw.pietrzyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Lee Jones , Sylvain Lemieux , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ludovic.barre-qxv4g6HH51o@public.gmane.org, olivier.bideau-qxv4g6HH51o@public.gmane.org, amelie.delaunay-qxv4g6HH51o@public.gmane.org, gabriel.fernandez.st-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Arvind Yadav List-Id: devicetree@vger.kernel.org On 07/18, Vladimir Zapolskiy wrote: > On 07/18/2017 10:53 AM, gabriel.fernandez-qxv4g6HH51o@public.gmane.org wrote: > > From: Gabriel Fernandez > > } > > +EXPORT_SYMBOL_GPL(clk_gate_is_enabled); > > > > const struct clk_ops clk_gate_ops = { > > .enable = clk_gate_enable, > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > > index c59c625..e9587ab 100644 > > --- a/include/linux/clk-provider.h > > +++ b/include/linux/clk-provider.h > > @@ -343,6 +343,7 @@ struct clk_hw *clk_hw_register_gate(struct device *dev, const char *name, > > u8 clk_gate_flags, spinlock_t *lock); > > void clk_unregister_gate(struct clk *clk); > > void clk_hw_unregister_gate(struct clk_hw *hw); > > +int clk_gate_is_enabled(struct clk_hw *hw); > > Here the prefix does not reflect the type of its argument, it might be > acceptable for a veiled function, but it is not wanted for the exported > function. Something like clk_hw_gate_is_enabled() is expected here, but > again, let's firstly come to an agreement, that the export is needed. > I'd prefer clk_gate_is_enabled() as it's not a struct clk_hw_gate, it's a struct clk_gate and there isn't any requirement for function names to reflect the type of the argument. That's what we have type analysis for. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html