From: Varadarajan Narayanan <varada@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
bhelgaas@google.com, robh+dt@kernel.org, mark.rutland@arm.com,
kishon@ti.com, sboyd@codeaurora.org, vivek.gautam@codeaurora.org,
fengguang.wu@intel.com, weiyongjun1@huawei.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
smuthayy <smuthayy@codeaurora.org>
Subject: Re: [PATCH 7/7] PCI: dwc: qcom: Add support for IPQ8074 PCIe controller
Date: Wed, 19 Jul 2017 14:59:13 +0530 [thread overview]
Message-ID: <20170719092905.GA13546@codeaurora.org> (raw)
In-Reply-To: <81d75c74-df15-cc9d-c07c-dd6f5cc30d18@mm-sol.com>
Stan,
On Wed, Jul 19, 2017 at 10:12:45AM +0300, Stanimir Varbanov wrote:
> Hi,
>
> On 07/19/2017 09:49 AM, Varadarajan Narayanan wrote:
> > On Tue, Jul 18, 2017 at 09:44:38AM -0700, Bjorn Andersson wrote:
> >> On Tue 18 Jul 02:58 PDT 2017, Varadarajan Narayanan wrote:
> >>
> >>> On Mon, Jul 17, 2017 at 03:07:18PM -0700, Bjorn Andersson wrote:
> >>>> On Mon 17 Jul 05:04 PDT 2017, Varadarajan Narayanan wrote:
> >> [..]
> >>>>
> >>>> Can you confirm that this is actually version 4 of this block? Or are we
> >>>> just incrementing an arbitrary number here?
> >>>
> >>> This is not exactly the 4th version of the block. However, it is
> >>> a different version than the ones that are already supported in
> >>> this driver. Since the existing driver didn't exactly tie it with
> >>> the block IP version, I too followed the same versioning
> >>> convention.
> >>>
> >>
> >> Do you have a block IP version that you could base your numbering on, to
> >> break the trend? (We should go back and fix up the others as well)
> >
> > Presently, the driver supports the ipq8064, apq8064, apq8084,
> > msm8996, ipq4019 and ipq8074. The SoCs, qcom_pcie_ops version and
> > the block IP versions are as follows.
> >
> > ipq8064 - v0 - 2.1.0
> > apq8064 - v0 - 2.1.0
> > apq8084 - v1 - 1.0.0
> > msm8996 - v2 - 2.3.2
> > ipq4019 - v3 - 2.4.0
> > ipq8074 - v4 - 2.3.3
>
> That's nice, but I think we need the Synopsys IP versions too, can you
> provide such an information and after that we can decide how the names
> should look like.
Sorry, I posted v2 before I saw this e-mail. Will post v3 based
on what naming style is decided.
The SoCs, qcom_pcie_ops version, the block IP version and
Synopsys IP versions are as follows.
ipq8064 - v0 - 2.1.0 - 4.01a
apq8064 - v0 - 2.1.0 - 4.01a
apq8084 - v1 - 1.0.0 - 4.11a
msm8996 - v2 - 2.3.2 - 4.21a
ipq4019 - v3 - 2.4.0 - 4.20a
ipq8074 - v4 - 2.3.3 - 4.30a
Thanks
Varada
> > I will rename the qcom_pcie_ops structure and related functions
> > with the block IP version instead of vX numbering and post the
> > patch.
>
>
>
> regards,
> Stan
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2017-07-19 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 12:03 [PATCH 0/7] Add support for IPQ8074 PCIe phy and controller Varadarajan Narayanan
2017-07-17 12:03 ` [PATCH 1/7] dt-bindings: phy: qmp: Add output-clock-names Varadarajan Narayanan
[not found] ` <1500293043-1887-2-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-17 20:15 ` Rob Herring
2017-07-17 12:03 ` [PATCH 2/7] dt-bindings: phy: qmp: Add support for QMP phy in IPQ8074 Varadarajan Narayanan
2017-07-17 20:16 ` Rob Herring
2017-07-17 12:03 ` [PATCH 3/7] phy: qcom-qmp: Fix phy pipe clock name Varadarajan Narayanan
[not found] ` <1500293043-1887-4-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-17 22:30 ` Bjorn Andersson
2017-07-18 8:54 ` Varadarajan Narayanan
2017-07-18 16:56 ` Bjorn Andersson
2017-07-19 3:08 ` Vivek Gautam
2017-07-19 3:10 ` Vivek Gautam
2017-07-17 12:04 ` [PATCH 4/7] phy: qcom-qmp: Handle unavailable registers Varadarajan Narayanan
2017-07-17 12:04 ` [PATCH 5/7] phy: qcom-qmp: Add support for IPQ8074 Varadarajan Narayanan
2017-07-17 12:04 ` [PATCH 6/7] dt-bindings: pci: qcom: " Varadarajan Narayanan
2017-07-17 20:17 ` Rob Herring
2017-07-17 12:04 ` [PATCH 7/7] PCI: dwc: qcom: Add support for IPQ8074 PCIe controller Varadarajan Narayanan
2017-07-17 22:07 ` Bjorn Andersson
2017-07-18 9:58 ` Varadarajan Narayanan
2017-07-18 16:44 ` Bjorn Andersson
2017-07-19 6:49 ` Varadarajan Narayanan
2017-07-19 7:12 ` Stanimir Varbanov
2017-07-19 9:29 ` Varadarajan Narayanan [this message]
2017-07-19 10:06 ` Vivek Gautam
2017-07-19 15:41 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719092905.GA13546@codeaurora.org \
--to=varada@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=smuthayy@codeaurora.org \
--cc=svarbanov@mm-sol.com \
--cc=vivek.gautam@codeaurora.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).