From: Varadarajan Narayanan <varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sham Muthayyan <smuthayy-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH v4 01/14] spi: qup: Enable chip select support
Date: Thu, 20 Jul 2017 11:00:29 +0530 [thread overview]
Message-ID: <20170720053029.GA25583@codeaurora.org> (raw)
In-Reply-To: <20170717160151.teozg2ni4mqxotbd-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
Brown,
On Mon, Jul 17, 2017 at 05:01:51PM +0100, Mark Brown wrote:
> On Tue, Jun 27, 2017 at 03:15:18PM +0530, Varadarajan Narayanan wrote:
>
> > the chip select support was removed earlier in commit
> > 4a8573abe965115bc5b064401fd669b74e985258. Since the chip
>
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise
> travelling so this is even more pressing for me than just being about
> making things a bit easier to read.
Sorry. The commit being referred to is (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4a8573abe965115bc5b064401fd669b74e985258)
commit 4a8573abe965115bc5b064401fd669b74e985258
Author: Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Date: Thu Jun 12 14:34:10 2014 -0500
spi: qup: Remove chip select function
This patch removes the chip select function. Chip select should instead be
supported using GPIOs, defining the DT entry "cs-gpios", and letting the SPI
core assert/deassert the chip select as it sees fit.
The chip select control inside the controller is buggy. It is supposed to
automatically assert the chip select based on the activity in the controller,
but it is buggy and doesn't work at all. So instead we elect to use GPIOs.
Signed-off-by: Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Signed-off-by: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Will update the commit log and repost the patches.
Thanks
Varada
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-07-20 5:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:45 [PATCH v4 00/14] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 01/14] spi: qup: Enable chip select support Varadarajan Narayanan
2017-07-17 16:01 ` Mark Brown
[not found] ` <20170717160151.teozg2ni4mqxotbd-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-07-20 5:30 ` Varadarajan Narayanan [this message]
[not found] ` <1498556731-13087-2-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-20 7:03 ` Geert Uytterhoeven
[not found] ` <1498556731-13087-1-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-06-27 9:45 ` [PATCH v4 02/14] spi: qup: Setup DMA mode correctly Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 03/14] spi: qup: Add completion structures for DMA Varadarajan Narayanan
2017-07-17 16:02 ` Mark Brown
2017-06-27 9:45 ` [PATCH v4 04/14] spi: qup: Add completion timeout Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 06/14] spi: qup: Fix error handling in spi_qup_prep_sg Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 05/14] spi: qup: Place the QUP in run mode before DMA Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 07/14] spi: qup: Fix transaction done signaling Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 08/14] spi: qup: Do block sized read/write in block mode Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 09/14] spi: qup: refactor spi_qup_io_config into two functions Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 10/14] spi: qup: call io_config in mode specific function Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 11/14] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 12/14] spi: qup: refactor spi_qup_prep_sg Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 13/14] spi: qup: allow multiple DMA transactions per spi xfer Varadarajan Narayanan
2017-06-27 9:45 ` [PATCH v4 14/14] spi: qup: Ensure done detection Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720053029.GA25583@codeaurora.org \
--to=varada-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=smuthayy-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).