From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver Date: Fri, 21 Jul 2017 13:37:12 -0700 Message-ID: <20170721203712.GH19878@codeaurora.org> References: <1500474344-9832-1-git-send-email-gabriel.fernandez@st.com> <1500474344-9832-4-git-send-email-gabriel.fernandez@st.com> <11c37627-a39b-7f2d-d0d4-af312eac8668@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vladimir Zapolskiy Cc: Gabriel FERNANDEZ , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Nicolas Pitre , Arnd Bergmann , "daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "andrea.merello-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "radoslaw.pietrzyk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , Lee Jones , Sylvain Lemieux , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-kernel-u79uwXL29TZNg+MwTxZMZA@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/20, Vladimir Zapolskiy wrote: > Hi Gabriel, > > On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: > > Hi Vladimir, > > > > > > On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > >> Hello Gabriel, > >> > >> On 07/19/2017 05:25 PM, gabriel.fernandez-qxv4g6HH51o@public.gmane.org wrote: > >>> From: Gabriel Fernandez > >>> + > >>> + rcc: rcc@58024400 { > >> 'rcc' as a generic device node name is awkward. > >> > >> I believe the main function of the device is clock controller (unlikely > >> a generic reset controller can be converted into a clock controller), > >> the locations of the document and device driver also indicate that > >> primarily it is a clock controller, so I suggest to replace device node > >> name with 'clock-controller' like below: > > I prefer to keep rcc node name, to be coherent with the other ST > > platforms (STM32F4/F7) > > the thing is, a device node name is expected to comply with ePAPR or > the devicetree specification, which says > > The name of a node should be somewhat generic, reflecting > the function of the device and not its precise programming model. > > If devicetree and CCF maintainers are fine with 'rcc', I won't object, > my role is just to emphasize the found issue and recommend to use another > and more common name 'clock-controller', it is a simple and fortunately > backward compatible change to other ST platforms as well. Yes. It should be generic so clock-controller or clock-reset-controller is appropriate here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html